Add UnavailableReason for MLXLanguageModel#138
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an explicit UnavailableReason for MLXLanguageModel so it can report whether a model is actually loaded (or failed to load), addressing Issue #137.
Changes:
- Introduces
MLXLanguageModel.UnavailableReasonwithnotLoaded/failedToLoad(String)and a customavailabilityimplementation. - Extends the shared MLX model context cache to track and surface the most recent load failure per model key.
- Adds tests verifying availability transitions for both a nonexistent model and a successful load.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/AnyLanguageModelTests/MLXLanguageModelTests.swift | Adds test cases asserting .notLoaded → .failedToLoad on load failure and .notLoaded → .available on successful load. |
| Sources/AnyLanguageModel/Models/MLXLanguageModel.swift | Implements real availability reporting by tracking cached contexts and last load failures in the shared cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for the quick resolution @mattt !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #137