Release 4.3.0#625
Conversation
oschwald
commented
May 12, 2026
oschwald
commented
- Update lock file
- Update geoip2 to 5.1.0
- Set release date
- Preparing for 4.3.0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 4.3.0 across the CHANGELOG, README, and pom.xml, while also upgrading the geoip2 dependency and the Java tool version in mise.lock. A review comment suggests reverting the change to japicmp.baselineVersion, as updating it to the current release version would bypass binary compatibility checks and could lead to build issues.
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <!-- Baseline version for API compatibility checking. Update after each release. --> | ||
| <japicmp.baselineVersion>4.2.0</japicmp.baselineVersion> | ||
| <japicmp.baselineVersion>4.3.0</japicmp.baselineVersion> |
There was a problem hiding this comment.
The japicmp.baselineVersion should remain at 4.2.0 for this release. This property defines the baseline version used to check for binary compatibility; setting it to the version currently being released (4.3.0) will compare the build against itself, effectively bypassing the check. Additionally, as noted in the comment on line 265, this should be updated after the release. Updating it now may also cause build failures if the CI environment cannot resolve the yet-to-be-released version 4.3.0 from the repositories.
| <japicmp.baselineVersion>4.3.0</japicmp.baselineVersion> | |
| <japicmp.baselineVersion>4.2.0</japicmp.baselineVersion> |
2 participants
