Merged
Conversation
lemald
reviewed
Mar 31, 2026
| | `#{parent_pointer}/attributes/closed_timestamp` | Time to send an all clear notification | | ||
| | `#{parent_pointer}/attributes/last_push_notification_timestamp` | Time to send a new or updated alert notification | | ||
| | `#{parent_pointer}/attributes/closed_timestamp` | Time the alert was closed. | | ||
| | `#{parent_pointer}/attributes/last_push_notification_timestamp` | Time to send a new or updated alert notification. Send an "all clear" if equal to closed_timestamp. | |
Member
There was a problem hiding this comment.
nitpick: could you adjust the length of the other rows of the ASCII art table to match?
Contributor
Author
There was a problem hiding this comment.
Good call, it ended up looking absurd in my editor so I changed it to a grid table. Not sure if there are any implications for how this renders in the swagger docs?
lemald
approved these changes
Apr 1, 2026
Member
lemald
left a comment
lemald
left a comment
There was a problem hiding this comment.
Looks good to me, I'd just recommend either running it locally or deploying to a dev environment to confirm that the table looks correct before merging.
Contributor
Author
|
@lemald good call on checking - the multiline table was wacky, so reverted for the extra wide rows which looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: No ticket
From a conversation in this ticket thread. The closed timestamp is always populated, and should be used in combination with
last_push_notification_timestampto determine if an all clear notification should be sent.