Trip Planner [Fix]: Out of system transfer logic#3205
Open
lvachon1 wants to merge 2 commits into
Open
Conversation
…ansfers to ensure those transfers happen in the same (or connected) stations. This is to handle the cases where OTP suggests walking between stations, but incorrectly counted that as a valid transfer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐞 Trip Planner | Fix out of system transfer logic
Implementation
Added maybe_transfer? cases to specifically handle subway -> subway transfers to ensure those happen in the same (or connected) stations. This is to handle the cases where OTP suggests walking between stations, but the fare was incorrectly calculated as if that was an in-fare transfer.
Screenshots
Branch
Dev
How to test
http://localhost:4001/trip-planner?plan=hsQVX3VudXNlZF9kYXRldGltZV90eXBlxADEEl91bnVzZWRfd2hlZWxjaGFpcsQAxAhkYXRldGltZcQgMjAyNi0wNS0yMlQxMjo1MDo0Ny4xMzQ4NTItMDQ6MDDEBGZyb22ExAhsYXRpdHVkZctARS_O2RaHK8QJbG9uZ2l0dWRly8BRx5y2hIvrxARuYW1lxDlIYXJ2YXJkIFNxdWFyZSwgQnJhdHRsZSBTdHJlZXQsIENhbWJyaWRnZSwgTUEsIDAyMTM4LCBVU0HEB3N0b3BfaWTEAMQFbW9kZXOJxANCVVPEBHRydWXEBUZFUlJZxAR0cnVlxARSQUlMxAR0cnVlxAZTVUJXQVnEBHRydWXEDl9wZXJzaXN0ZW50X2lkxAEwxAtfdW51c2VkX0JVU8QAxA1fdW51c2VkX0ZFUlJZxADEDF91bnVzZWRfUkFJTMQAxA5fdW51c2VkX1NVQldBWcQAxAJ0b4TECGxhdGl0dWRly0BFMxYJVsDXxAlsb25naXR1ZGXLwFG_nYg7o0TEBG5hbWXES1dvbmRlcmxhbmQgR3JleWhvdW5kIFBhcmssIDE5MCBSZXZlcmUgQmVhY2ggUGFya3dheSwgUmV2ZXJlLCBNQSwgMDIxNTEsIFVTQcQHc3RvcF9pZMQA
Any other route that involves a red to blue transfer should work.
Confirm that leaving one station and entering another on foot is included in the fare calculation.
Confirm that transfers within the fare gates are still free.