[WC-3344] Placement of filter dropdowns on small viewports#2152
Open
[WC-3344] Placement of filter dropdowns on small viewports#2152
Conversation
r0b1n
force-pushed
the
fix/filter-selector-best-placement
branch
from
ff6a14f to
7e5abaf
Compare
r0b1n
force-pushed
the
fix/filter-selector-best-placement
branch
from
7e5abaf to
acec1ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
With previous strategy, overflown dropdowns were not positioned to be at the best placement. This worked suboptimal for small screens. This change makes it always try the best placement. Seems this is working better for filter selectors.