Skip to content

fix: address PR #28 review follow-ups#48

Merged
ako merged 2 commits intomainfrom
fix/pr28-followup
Mar 28, 2026
Merged

fix: address PR #28 review follow-ups#48
ako merged 2 commits intomainfrom
fix/pr28-followup

Conversation

@ako
Copy link
Copy Markdown
Collaborator

@ako ako commented Mar 28, 2026

Summary

  • Fix gallery .mxcli/widgets/gallery.def.json to match embedded definition: FILTERSPLACEHOLDERFILTER, add missing "default": "Single" for itemSelection
  • Log LoadUserDefinitions errors in cmd_widget.go and lsp_completion.go instead of silently swallowing
  • Translate Chinese headers in design doc to English

Test plan

  • make build — compiles clean
  • make test — all tests pass
  • Verified gallery defs match between embedded and project-level

🤖 Generated with Claude Code

ako and others added 2 commits March 28, 2026 08:56
Load mermaid v11 from CDN and render ```mermaid code blocks client-side.
No build dependency needed — works with existing CI workflow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix gallery .mxcli/widgets/gallery.def.json: FILTERSPLACEHOLDER → FILTER
  to match embedded def and DESCRIBE output
- Fix gallery .mxcli/widgets/gallery.def.json: add missing "default": "Single"
  for itemSelection to match embedded def
- Fix cmd_widget.go: log LoadUserDefinitions errors instead of swallowing
- Fix lsp_completion.go: log LoadUserDefinitions errors instead of swallowing
- Translate Chinese headers in design doc to English
- Fix FILTERSPLACEHOLDER → FILTER in design doc examples

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ako ako merged commit 62196a2 into main Mar 28, 2026
8 of 10 checks passed
@ako ako temporarily deployed to github-pages March 28, 2026 09:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant