fix(staticpool): guard outbound queue index access#1815
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(staticpool): guard outbound queue index access#1815robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Return null for out-of-range PacketQueue::itemAt() indexes instead of indexing raw storage directly. Prevents out-of-bounds reads when callers probe outbound entries beyond the current queue length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds bounds enforcement for outbound queue indexing in static pool packet management.
Bug
PacketQueue::itemAtdid not validate index bounds before dereferencing queue storage.Trigger
Request outbound queue items with an index outside current queue range (directly or through higher-level accessors like outbound-by-index paths).
Impact
Fix
Added explicit bounds checks in
itemAt; invalid indices are rejected instead of dereferenced.