Seeed Studio T1000-E: move to new UI#1850
Open
sybrenstuvel wants to merge 2 commits intomeshcore-dev:devfrom
Open
Seeed Studio T1000-E: move to new UI#1850sybrenstuvel wants to merge 2 commits intomeshcore-dev:devfrom
sybrenstuvel wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
Remove trailing whitespace, and ensure that files end in a newline. No functional changes.
The compiler is switched from `examples/companion_radio/ui-orig` to `examples/companion_radio/ui-new`. The handling of the momentary button was switched from `T1000eBoard::buttonStateChanged()` to a `MomentaryButton` in `variants/t1000-e/target.cpp`. Everything still seems to work properly. I briefly tested the room server and repeater modes, and did a bit more testing of the companion (USB & BLE) modes.
robekl
reviewed
Feb 26, 2026
|
|
||
| #ifdef DISPLAY_CLASS | ||
| NullDisplayDriver display; | ||
| DISPLAY_CLASS display; |
There was a problem hiding this comment.
should this match the type of display in target.cpp? (both DISPLAY_CLASS)
Author
There was a problem hiding this comment.
It should -- I started to clean things up (because what's the point of the DISPLAY_CLASS define if it's not used), but then decided against this change. But, evidently, I didn't roll it back entirely.
There's more of these issues in the T1000 code, with mismatched #ifdefs and other non-uses of the define (like using NullDisplayDriver here directly, instead of the defined one).
How about this: I'll remove this change from this PR, and after this has landed, go over variants/t1000-e for another cleanup PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is switched from
examples/companion_radio/ui-origtoexamples/companion_radio/ui-new. The handling of the momentary buttonwas switched from
T1000eBoard::buttonStateChanged()to aMomentaryButtoninvariants/t1000-e/target.cpp.Everything still seems to work properly. I briefly tested the room
server and repeater modes, and did a bit more testing of the companion
(USB & BLE) modes.
The desired GPS state is now saved, and survives reboots. The
momentary button also still works properly.
Ref: #989
I've included one little extra change in a separate commit, to remove trailing whitespace and ensure each file (related to the T1000e, I didn't go over the entire source tree) has consistent newlines. Let me know if I can keep that commit in this PR, or if such cleanups should be done in a separate PR.