Fixed: Popup box just a black bar on heltec epaper nodes#2693
Open
doormatt-dev wants to merge 1 commit into
Open
Fixed: Popup box just a black bar on heltec epaper nodes#2693doormatt-dev wants to merge 1 commit into
doormatt-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The drawing functions in /src/helpers/ui/E213Display.cpp and /src/helpers/ui/E290Display.cpp did not implement any sort of colour changing on rectangles, text and bitmaps. This results in the following black rectangle appearing:
20260604_171501.1.mp4
How to replicate:
Simply install the official meshcore firmware on any of the Heltec e-paper boards. The black bar will appear on the recent contacts page when cycling through the pages in forward order (not in reverse order but that's a different issue, it shouldn't try to do a popup at all there imo) and when sending an advert via the companion itself (not when triggering an advert through the app).
Fix:
The display.setColor() function was implemented properly. A variable for the colour was added like in the implementation of all the other displays. The fix is fully functional. Changing text and bitmap colour is also supported now although it is not used so far. The comment about text colours on monochrome screens was updated to note that the colours on epaper screens are inverted compared to other monochrome displays.
20260604_173153.1.mp4
This PR is a reworked version of PR #2554
I cleaned up the code a little bit more and am not trying to PR to main branch anymore