Skip to content

remove dependencies on direnv and nix#2699

Open
notmike-5 wants to merge 1 commit into
meshcore-dev:mainfrom
notmike-5:remove-nix-dep
Open

remove dependencies on direnv and nix#2699
notmike-5 wants to merge 1 commit into
meshcore-dev:mainfrom
notmike-5:remove-nix-dep

Conversation

@notmike-5
Copy link
Copy Markdown

remove dependencies on direnv and nix

remove dependencies on direnv and nix
@liamcottle
Copy link
Copy Markdown
Member

Howdy. Please provide explanation why this needs to be removed. It was added in #205 Also please ensure pull requests are opened against the dev branch.

@notmike-5
Copy link
Copy Markdown
Author

notmike-5 commented Jun 6, 2026

From what I can tell direnv and nix are not dependencies of MeshCore. The file .envrc is usually left to users to setup their own local environments as suits their needs. The file .envrc in the repo currently enforces the development environment of some nix/direnv users onto all users, overriding whatever particular environments users may have themselves. #205 adds .direnv/ to the .gitignore in recognition that this environment is not needed by most users. It is advisable to similarly remove .envrc from version control since the environment may need look different for every different clone of the repo.

So, my claim is that #205 should really have added .envrc and .direnv/ to gitignore.txt and left it at that. The other files are particular to the authors' development environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants