Skip to content

fix(nrf52): fix poweroff CLI command for T114 and RAK4631 #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jirogit wants to merge 3 commits into
base: dev
Choose a base branch
from
+13 −0
Open

fix(nrf52): fix poweroff CLI command for T114 and RAK4631 #2701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81587f8
fix(t114): delegate powerOff() to initiateShutdown() for proper SYSTE…
jirogit Jun 6, 2026
d9e9eb9
fix(rak4631): add powerOff() delegating to initiateShutdown()
jirogit Jun 6, 2026
90b07b5
fix(rak4631): clear DIO1 SENSE in initiateShutdown() to prevent wakeup
jirogit Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions variants/heltec_t114/T114Board.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,14 @@ class T114Board : public NRF52BoardDCDC {
#ifdef LED_PIN
digitalWrite(LED_PIN, HIGH);
#endif
#ifdef NRF52_POWER_MANAGEMENT
initiateShutdown(SHUTDOWN_REASON_USER);
#else
#if ENV_INCLUDE_GPS == 1
pinMode(GPS_EN, OUTPUT);
digitalWrite(GPS_EN, LOW);
#endif
sd_power_system_off();
#endif
}
};
3 changes: 3 additions & 0 deletions variants/rak4631/RAK4631Board.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ const PowerMgtConfig power_config = {
void RAK4631Board::initiateShutdown(uint8_t reason) {
// Disable LoRa module power before shutdown
digitalWrite(SX126X_POWER_EN, LOW);
// RAK4631 has no buttons; clear DIO1 SENSE (set by RadioLib) so the
// floating pin doesn't trigger an immediate wakeup from SYSTEMOFF.
nrf_gpio_cfg_default(P_LORA_DIO_1);

if (reason == SHUTDOWN_REASON_LOW_VOLTAGE ||
reason == SHUTDOWN_REASON_BOOT_PROTECT) {
Expand Down
6 changes: 6 additions & 0 deletions variants/rak4631/RAK4631Board.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,10 @@ class RAK4631Board : public NRF52BoardDCDC {
const char* getManufacturerName() const override {
return "RAK 4631";
}

#ifdef NRF52_POWER_MANAGEMENT
void powerOff() override {
initiateShutdown(SHUTDOWN_REASON_USER);
}
#endif
};