Fix message status datetime not showing in MessageBird::Recipient object#81
Open
karissekjw wants to merge 1 commit intomessagebird:masterfrom
Open
Fix message status datetime not showing in MessageBird::Recipient object#81karissekjw wants to merge 1 commit intomessagebird:masterfrom
karissekjw wants to merge 1 commit intomessagebird:masterfrom
Conversation
Vuta
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Based on MessageBird's API documentation,
MessageBird::Recipientobject containsstatusDatetime. But the library is currently throwing an error when attempting to retrievestatus_datetimeSolution
After some digging, notice that this bug is due to incorrect method name when executing
map_hash_elements_to_selfmethod inMessage::Base. This PR renames the method so elements can be mapped to the method correctly and retrievestatusDatetimesuccessfullyAfter this fix, the object looks like this:
Also added a test case to ensure that the change works as expected