Fix channel id typo in conversation methods#87
Open
caiopardal wants to merge 1 commit intomessagebird:masterfrom
Open
Fix channel id typo in conversation methods#87caiopardal wants to merge 1 commit intomessagebird:masterfrom
caiopardal wants to merge 1 commit intomessagebird:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL.DR.
This PR fixes this issue
Issue
Based on MessageBird's Conversations API documentation, the
start_conversationmethod should use a parameter namedChannelId, but at theclient.rbfile, it's being passed achannel_idparam that generates a MessageBird::ServerException when trying to use the start_conversation methodSolution
As mentioned in the referenced issue, the solution was just to change and fix the typo at the channel_id parameter:
channel_id->ChannelId, exactly the same as in the documentation.Also fixed the tests to ensure that the change works as expected