RenderCallbackRule: Check if method exists in trustedCallbacks#562
Open
Boegie wants to merge 11 commits intomglaman:mainfrom
Open
RenderCallbackRule: Check if method exists in trustedCallbacks#562Boegie wants to merge 11 commits intomglaman:mainfrom
Boegie wants to merge 11 commits intomglaman:mainfrom
Conversation
Owner
|
😩 That is because |
mglaman
requested changes
Sep 27, 2023
Owner
mglaman
left a comment
There was a problem hiding this comment.
We need to run PHPStan with phpstan-drupal and this PR against Drupal core using --debug, at least against RendererPlaceholdersTest to get the full stacktrace. I don't know why PHPStan can detect but PHP's internal reflection breaks.
Comment on lines
+225
to
232
| $classMap = [ | ||
| '\\Drupal\\Tests\\Core\\Render\\BubblingTest' => $this->drupalRoot . '/core/tests/Drupal/Tests/Core/Render/RendererBubblingTest.php', | ||
| '\\Drupal\\Tests\\Core\\Render\\PlaceholdersTest' => $this->drupalRoot . '/core/tests/Drupal/Tests/Core/Render/RendererTestBase.php', | ||
| '\\Drupal\\Tests\\Core\\Render\\TestAccessClass' => $this->drupalRoot . '/core/tests/Drupal/Tests/Core/Render/RendererTest.php', | ||
| '\\Drupal\\Tests\\Core\\Render\\TestCallables' => $this->drupalRoot . '/core/tests/Drupal/Tests/Core/Render/RendererTest.php', | ||
| ]; | ||
| $this->autoloader->addClassMap($classMap); | ||
| } |
Owner
There was a problem hiding this comment.
This didn't fix the internal error:
Error: Internal error: Internal error: Method of class Drupal\Tests\Core\Render\BubblingTest cannot be used as the class does not exist in file /home/runner/work/_temp/drupal/core/tests/Drupal/Tests/Core/Render/RendererBubblingTest.php
I don't know what to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #561