Open
Conversation
ceesgeene
force-pushed
the
daterange-field-type
branch
from
7105f8b to
1023a10
Compare
ceesgeene
force-pushed
the
daterange-field-type
branch
from
1023a10 to
33bff49
Compare
ceesgeene
force-pushed
the
daterange-field-type
branch
2 times, most recently
from
8de9dcb to
08a3eaa
Compare
mglaman
reviewed
Jul 12, 2024
Comment on lines
8
to
10
| * @property-read null $date | ||
| * Even though this extends DateTimeItem, the date property does not actually | ||
| * exist. It is not possible to undo a property definition. |
ceesgeene
force-pushed
the
daterange-field-type
branch
from
08a3eaa to
517664a
Compare
ceesgeene
force-pushed
the
daterange-field-type
branch
from
517664a to
9b4a099
Compare
# Conflicts: # tests/src/Type/data/field-types.php
mglaman
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #369
Note this MR is a follow up on #785
Also please carefully review the
@property-read null $date. Not sure if this is the best solution. Maybe we should just remove theextends DateTimeItem.