Add startup robustness API (waitUntilReady, timeout, offline, load error)#11
Draft
microbit-matt-hillsdon wants to merge 4 commits intomainfrom
Draft
Add startup robustness API (waitUntilReady, timeout, offline, load error)#11microbit-matt-hillsdon wants to merge 4 commits intomainfrom
microbit-matt-hillsdon wants to merge 4 commits intomainfrom
Conversation
…ror) Move MakeCode iframe startup detection into the library so consumers don't need to reimplement timeout, offline, and load error handling. - Add waitUntilReady() on MakeCodeFrameDriver that races editor readiness against configurable timeout, offline detection, and iframe load errors - Add startUpTimeout option (default 90s) - Add notifyLoadError() and isReady getter - Export StartUpResult and StartUpFailure types
Tests cover ready, timeout, offline, load error, and isReady lifecycle. Adds vitest and happy-dom as dev dependencies.
Deploying makecode-embed with
|
| Latest commit: |
d39a319
|
| Status: | 🚫 Build failed. |
microbit-matt-hillsdon
force-pushed
the
load-error
branch
from
895a6d8 to
d39a319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readiness against configurable timeout, offline detection, and
iframe load errors
Draft for testing with ml-trainer where some of this logic came from (offline stuff is new).