Skip to content

micropython/mip/mip: Add an alias for codeberg repos. #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agatti wants to merge 1 commit into
base: master
Choose a base branch
from
Open

micropython/mip/mip: Add an alias for codeberg repos. #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micropython/mip/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
metadata(version="0.4.2", description="On-device package installer for network-capable boards")
metadata(version="0.5.0", description="On-device package installer for network-capable boards")

require("requests")

Expand Down
47 changes: 21 additions & 26 deletions micropython/mip/mip/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,20 @@
_PACKAGE_INDEX = const("https://micropython.org/pi/v2")
_CHUNK_SIZE = const(128)

allowed_mip_url_prefixes = ("http://", "https://", "github:", "gitlab:")
# Since all URLs are accessed via HTTPS, the URL scheme has to be omitted here.
# The first three format parameters are assumed to be the organisation, the
# repository names, and the branch/tag name, in this order.
_HOSTS = {
# https://codeberg.org/api/v1/repos/{org}/{repo}/raw/{path}?ref={branch}
"codeberg:": "codeberg.org/api/v1/repos/{}/{}/raw/{p}?ref={}",
# https://raw.githubusercontent.com/{org}/{repo}/{branch}/{path}
"github:": "raw.githubusercontent.com/{}/{}/{}/{p}",
# https://gitlab.com/{org}/{repo}/-/raw/{branch}/{path}
"gitlab:": "gitlab.com/{}/{}/-/raw/{}/{p}",
}

# ruff: noqa: RUF005 - tuple construction with list destructuring is not supported.
allowed_mip_url_prefixes = tuple(["http://", "https://"] + list(_HOSTS.keys()))
Copy link
Copy Markdown
Member

@dpgeorge dpgeorge Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest leaving this as a literal tuple of strings. That might actually produce smaller bytecode, and it'll definitely be faster to import because it's just a constant.

Actually, this could even be a true const:

_ALLOWED_MIP_URL_PREFIXES = const(("http://", ...))

which should reduce code size.



# This implements os.makedirs(os.dirname(path))
Expand Down Expand Up @@ -62,31 +75,13 @@ def _check_exists(path, short_hash):


def _rewrite_url(url, branch=None):
if not branch:
branch = "HEAD"
if url.startswith("github:"):
url = url[7:].split("/")
url = (
"https://raw.githubusercontent.com/"
+ url[0]
+ "/"
+ url[1]
+ "/"
+ branch
+ "/"
+ "/".join(url[2:])
)
elif url.startswith("gitlab:"):
url = url[7:].split("/")
url = (
"https://gitlab.com/"
+ url[0]
+ "/"
+ url[1]
+ "/-/raw/"
+ branch
+ "/"
+ "/".join(url[2:])
for provider, url_format in _HOSTS.items():
if not url.startswith(provider):
continue
components = url[len(provider) :].split("/")
# Add https:// prefix to final URL.
return allowed_mip_url_prefixes[1] + url_format.format(
components[0], components[1], branch or "HEAD", p="/".join(components[2:])
)
return url

Expand Down
Loading