Mitigate Node Maglev artifact upload failures#2288
Open
aholstrup1 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies GitHub’s current mitigation for intermittent actions/upload-artifact failures related to the runner’s Node Maglev behavior by setting ACTIONS_RUNNER_DISABLE_NODE_MAGLEV: 1 on generated checkout and artifact upload steps. The change is scoped to AL-Go templates, relevant composite actions, and the custom-template e2e scenario, leaving the root repo maintenance workflows under .github/workflows untouched as intended.
Changes:
- Add
ACTIONS_RUNNER_DISABLE_NODE_MAGLEV: 1toactions/checkoutsteps across generated workflow templates. - Add the same env var to
actions/upload-artifactsteps in the reusable build workflows. - Update release notes and the custom-template e2e scenario to reflect/validate the generated workflow behavior.
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Templates/Per Tenant Extension/.github/workflows/UpdateGitHubGoSystemFiles.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/Troubleshooting.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/PushPowerPlatformChanges.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/PullPowerPlatformChanges.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/PublishToEnvironment.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/NextMinor.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/NextMajor.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/IncrementVersionNumber.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/DeployReferenceDocumentation.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/Current.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/CreateTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/CreatePerformanceTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/CreateOnlineDevelopmentEnvironment.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/Per Tenant Extension/.github/workflows/CreateApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/CICD.yaml | Add Maglev-disable env var to checkout steps in multiple jobs. |
| Templates/Per Tenant Extension/.github/workflows/AddExistingAppOrTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/Per Tenant Extension/.github/workflows/_BuildPowerPlatformSolution.yaml | Add Maglev-disable env var to checkout and upload-artifact steps. |
| Templates/Per Tenant Extension/.github/workflows/_BuildALGoProject.yaml | Add Maglev-disable env var to checkout steps and all upload-artifact steps. |
| Templates/AppSource App/.github/workflows/UpdateGitHubGoSystemFiles.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/Troubleshooting.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/PullRequestHandler.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/PublishToEnvironment.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/PublishToAppSource.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/NextMinor.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/NextMajor.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/IncrementVersionNumber.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/DeployReferenceDocumentation.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/Current.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/CreateTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/CreateRelease.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/CreatePerformanceTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/CreateOnlineDevelopmentEnvironment.yaml | Add Maglev-disable env var to checkout steps. |
| Templates/AppSource App/.github/workflows/CreateApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/CICD.yaml | Add Maglev-disable env var to checkout steps in multiple jobs. |
| Templates/AppSource App/.github/workflows/AddExistingAppOrTestApp.yaml | Add Maglev-disable env var to checkout step. |
| Templates/AppSource App/.github/workflows/_BuildALGoProject.yaml | Add Maglev-disable env var to checkout steps and all upload-artifact steps. |
| Actions/PullPowerPlatformChanges/action.yaml | Add Maglev-disable env var to the internal checkout step in the composite action. |
| Actions/DeployPowerPlatform/action.yaml | Add Maglev-disable env var to the internal checkout step in the composite action. |
| e2eTests/scenarios/CustomTemplate/runtest.ps1 | Update custom workflow content to include Maglev-disable env var on checkout step. |
| RELEASENOTES.md | Document the mitigation under Issue 2276. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated AL-Go workflows can intermittently fail in
actions/upload-artifactwhen the runner launches Node with Maglev enabled. This applies the current GitHub mitigation by settingACTIONS_RUNNER_DISABLE_NODE_MAGLEV: 1on generated checkout and artifact upload action steps, while preserving the existing action versions and pins.The change is limited to AL-Go templates, related composite actions, and the custom-template e2e workflow. Root repository maintenance workflows under
.github/workflowsare intentionally unchanged.Validation:
git diff --checkInvoke-Pester -Path '.\Tests\WorkflowSanitation', '.\Tests\CheckForUpdates.Action.Test.ps1'(91 passed)Related to: #2276