Skip to content

[Shopify] API 2026-01 uptake (backport to releases/27.1) — fix ImportPayout visibility#8686

Draft
Copilot wants to merge 4 commits into
releases/27.1from
copilot/fix-failing-github-actions-job-again
Draft

[Shopify] API 2026-01 uptake (backport to releases/27.1) — fix ImportPayout visibility#8686
Copilot wants to merge 4 commits into
releases/27.1from
copilot/fix-failing-github-actions-job-again

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Backport of the Shopify API 2026-01 uptake (#8366 + #8548) to releases/27.1, with a compilation fix: ImportPayout was declared local in ShpfyPaymentsAPI but the new test calls it externally, causing AL0132.

Root cause

// Before — inaccessible from test codeunit
local procedure ImportPayout(JPayout: JsonObject)

// After — accessible via internalsVisibleTo
internal procedure ImportPayout(JPayout: JsonObject)

Changes

App (src/Apps/W1/Shopify/App)

  • API version bump: 2025-07 → 2026-01
  • ShpfyPayout table: new External Trace Id (Text[250]) field; GraphQL queries updated to fetch externalTraceId
  • Inventory API: idempotency + retry logic rework (ShpfyInventoryAPI, ShpfyGQLModifyInventory)
  • Bulk operations: GetCurrentBulkOperation removal; updated GQL and subscriber
  • Returns: unverified return lines support (ShpfyReturnLine, ShpfyReturnsAPI, ShpfyGQLReturnLines/NextReturnLines); new ShpfyReturnLineType enum values
  • Metafields: article reference type (ShpfyMtfldTypeArticleRef, ShpfyMetafieldType enum)
  • Products: variant API pagination fixes (ShpfyVariantAPI, ShpfyGQLVariantById)
  • Tax Code deprecation (ObsoleteTag CLEAN28/CLEANSCHEMA31)
  • ID range extended to 30460; permission set updated

Tests (src/Apps/W1/Shopify/Test)

  • ShpfyPaymentsTest: adds UnitTestImportPayoutWithExternalTraceId verifying the new field is populated on import
  • Inventory, bulk ops, order refund tests updated to match new API behaviour
  • Codeunit 139593 → 134248 ID clash fix

github-actions Bot and others added 3 commits June 19, 2026 12:03
…8) (#8548)

Codeunit 139593 `"Shpfy Inventory Subscriber"` was reintroduced on the
release branch by the API 2026-01 uptake backport (PR #8366) but clashes
with the codeunit 139593 in the BCApps Shopify Connector Test 28.0.0.0
baseline, which is checked by BuildCop and the BC platform during NAV
gate validation (`VerifyApplicationChanges` failed in job 3581772, NAV
PR 248762).

## Fix

Renumber the codeunit from 139593 to **134248** and extend the existing
`134241-134247` `idRange` in `src/Apps/W1/Shopify/Test/app.json` to
`134248`.

134248 is confirmed free across:
- NAV source (`C:\depot\NAV2\App\Apps`, `Layers`, `Internal`, `Test`,
`Extension`)
- BCApps source on `main`, `releases/27.x`, and `releases/27.5`
- All 137 `.app` baselines in NAV2 (Shopify Test 25.8 through 29.0 and
every other app)

All other references to the codeunit use the name `"Shpfy Inventory
Subscriber"` rather than the ID, so no callers need to change.

Companion fix for releases/27.x: #8547.

Fixes
[AB#638060](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/638060)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build Apps (W1) (Default) [Shopify] API 2026-01 uptake (backport to releases/27.1) — fix ImportPayout visibility Jun 19, 2026
Copilot AI requested a review from djukicmilica June 19, 2026 11:44
@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-approval Workflow runs require maintainer approval to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants