Skip to content

[Shopify] API 2026-01 uptake — backport to releases/27.1 (fix ImportPayout accessibility)#8691

Open
Copilot wants to merge 2 commits into
releases/27.1from
copilot/fix-github-actions-job-another-one
Open

[Shopify] API 2026-01 uptake — backport to releases/27.1 (fix ImportPayout accessibility)#8691
Copilot wants to merge 2 commits into
releases/27.1from
copilot/fix-github-actions-job-another-one

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Backport of PR #8366 (Shopify API 2026-01 uptake) and PR #8548 (codeunit ID clash fix) to releases/27.1. CI was failing because the new UnitTestImportPayoutWithExternalTraceId test called PaymentsAPI.ImportPayout() directly, but ImportPayout was declared local ΓÇö inaccessible outside the codeunit.

Critical fix

  • ShpfyPaymentsAPI.Codeunit.al: local procedure ImportPayout ΓåÆ internal procedure ImportPayout

Payout ΓÇö External Trace Id (API 2026-01)

  • ShpfyPayout.Table.al: new field 16 "External Trace Id" (Text[250])
  • ShpfyPaymentsAPI.Codeunit.al: map externalTraceId JSON field into the new table field
  • ShpfyGQLPayouts / ShpfyGQLNextPayouts: add externalTraceId to GraphQL selection; fix payout filter from id:> ΓåÆ id:>=
  • ShpfyPaymentsTest.Codeunit.al: new test UnitTestImportPayoutWithExternalTraceId

Inventory API rework

  • Idempotency keys and retry logic in ShpfyInventoryAPI
  • New test infrastructure: ShpfyInventoryExportTest, ShpfyInventoryRetryScenario enum, ShpfyInventorySubscriber

Return lines

  • ShpfyReturnLine.Table.al / ShpfyReturnsAPI: unverified return line support
  • New ShpfyReturnLineType enum
  • Updated ShpfyGQLReturnLines / ShpfyGQLNextReturnLines queries

Metafields

  • New ShpfyMtfldTypeArticleRef codeunit implementing article reference metafield type
  • ShpfyMetafieldType enum: new ArticleReference value

Bulk operations

  • Removed ShpfyGQLBulkOperations codeunit (and associated CurrentBulkOperation* test resources)
  • ShpfyBulkOperationAPI / ShpfyBulkOperationMgt: updated to remove GetCurrentBulkOperation dependency

Products / Tax Code deprecation

  • ShpfyVariant, ShpfyVariants.Page, ShpfyVariantAPI, ShpfyCreateProduct, ShpfyProductExport: Tax Code marked obsolete (ObsoleteTag = CLEAN28/CLEANSCHEMA31)
  • ShpfyGQLVariantById: updated query

Misc

  • Codeunit ID clash fix: 139593 ΓåÆ 134248
  • ShpfyObjects.PermissionSet: updated for new objects

Fixes AB#639697

…Payout accessibility

Backport of PR #8366 (API 2026-01 uptake) and PR #8548 (codeunit ID clash fix).

Key fix: Change ImportPayout from 'local' to 'internal' procedure so test
UnitTestImportPayoutWithExternalTraceId can call it directly.

Changes:
- API version update from 2025-07 to 2026-01
- Inventory API rework with idempotency and retry logic
- Unverified return lines support
- Article reference metafield support
- Tax Code deprecation (ObsoleteTag CLEAN28/CLEANSCHEMA31)
- External Trace Id on Payout table (field 16)
- GetCurrentBulkOperation removal
- Pagination fixes (id:> to id:>=)
- Codeunit ID clash fix (139593 → 134248)
- ImportPayout: local → internal for test accessibility

Fixes CI failure: AL0132 'Shpfy Payments API' does not contain a definition for 'ImportPayout'
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for Build Apps [Shopify] API 2026-01 uptake — backport to releases/27.1 (fix ImportPayout accessibility) Jun 19, 2026
Copilot AI requested a review from djukicmilica June 19, 2026 12:01
@djukicmilica djukicmilica added the Linked Issue is linked to a Azure Boards work item label Jun 19, 2026
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 19, 2026
@github-actions github-actions Bot added this to the Version 27.1 milestone Jun 19, 2026
@djukicmilica djukicmilica marked this pull request as ready for review June 19, 2026 13:20
@djukicmilica djukicmilica requested a review from a team June 19, 2026 13:20
@djukicmilica djukicmilica requested review from a team as code owners June 19, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants