build: use C++17 standard for macOS compatibility #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern Apple SDK headers (macOS 26+, Xcode 17+) require elaborated enum base declarations which are not supported in C++11. This causes compilation failures with errors like: "non-defining declaration of enumeration with a fixed underlying type is only permitted as a standalone declaration" Setting CMAKE_CXX_STANDARD to 17 resolves this issue while maintaining backward compatibility with other platforms. Fixes microsoft#350 Signed-off-by: majiayu000 <1835304752@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CMAKE_CXX_STANDARDto 17 in the root CMakeLists.txtProblem
Modern Apple SDK headers (macOS 26+, Xcode 17+) use elaborated enum base declarations that require C++17:
Solution
The ggml submodule defaults to C++11 which doesn't support this syntax. Setting C++17 at the BitNet project level propagates to submodules and fixes the issue.
This has been confirmed working by @RobBW in issue #350 comments.
Fixes #350