[SPIR-V] countbit on 16+64 bit types#7997
Merged
Keenuts merged 7 commits intomicrosoft:mainfrom Dec 16, 2025
Merged
Conversation
The SPIR-V instruction can work on non-32 bit components, but only with VK maintenance 9, which seems to be hidden behing a feature bit. Implementing countbit on such types by converting to a 32-bit integer first. Should be ok. Fixes microsoft#7122
s-perron
reviewed
Dec 12, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Left needs to be right, and you link to the wrong issue in description.
s-perron
reviewed
Dec 15, 2025
Collaborator
Author
|
failure in the CI seems to be related to a macos machine failure. |
s-perron
approved these changes
Dec 16, 2025
Collaborator
Author
|
/azp run microsoft.DirectXShaderCompiler |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPIR-V instruction can work on non-32 bit components, but only with VK maintenance 9, which seems to be hidden behing a feature bit.
Implementing countbit on such types by converting to a 32-bit integer first. Should be ok.
Fixes #7494