Skip to content

[Bugfix][SM6.10] Allow LinAlgMatrix type in the validator #8441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V-FEXrt merged 3 commits into from
May 13, 2026
+38 −0
Merged

[Bugfix][SM6.10] Allow LinAlgMatrix type in the validator #8441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167fd82
[Bugfix][SM6.10] Allow LinAlgMatrix type in the validator
V-FEXrt May 11, 2026
ca22130
Add test
V-FEXrt May 11, 2026
38f3c94
tweak tests
V-FEXrt May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/DxilValidation/DxilValidation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2414,6 +2414,9 @@ static bool ValidateType(Type *Ty, ValidationContext &ValCtx,
// Allow HitObject type.
if (ST == HlslOP->GetHitObjectType())
return true;
// Allow LinAlgMatrix type.
if (dxilutil::IsHLSLLinAlgMatrixType(ST))
return true;
Comment thread
tex3d marked this conversation as resolved.
if (IsDxilBuiltinStructType(ST, HlslOP)) {
ValCtx.EmitTypeError(Ty, ValidationRule::InstrDxilStructUser);
Result = false;
Expand Down
35 changes: 35 additions & 0 deletions tools/clang/test/LitDXILValidation/LinAlgMatrix/linalgmatrix-type-allowed-in-dxil.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
; RUN: %dxv %s 2>&1 | FileCheck %s

; CHECK-NOT: uses a reserved prefix.
; CHECK-NOT: Validation failed.
; CHECK: Validation succeeded.

target datalayout = "e-m:e-p:32:32-i1:32-i8:8-i16:16-i32:32-i64:64-f16:16-f32:32-f64:64-n8:16:32:64"
target triple = "dxil-ms-dx"

%dx.types.LinAlgMatrixC8M16N16U0S0 = type { i8* }
%struct.ByteAddressBuffer = type { i32 }

define void @main() {
%1 = alloca %dx.types.LinAlgMatrixC8M16N16U0S0
ret void
}

!dx.targetTypes = !{!0}
!llvm.ident = !{!1}
!dx.version = !{!2}
!dx.valver = !{!2}
!dx.shaderModel = !{!3}
!dx.resources = !{!4}
!dx.entryPoints = !{!7}

!0 = !{%dx.types.LinAlgMatrixC8M16N16U0S0 undef, i32 8, i32 16, i32 16, i32 0, i32 0}
!1 = !{!"dxc(private) 1.9.0.5348 (issue-8433, 167fd829e-dirty)"}
!2 = !{i32 1, i32 10}
!3 = !{!"cs", i32 6, i32 10}
!4 = !{!5, null, null, null}
!5 = !{!6}
!6 = !{i32 0, %struct.ByteAddressBuffer* undef, !"", i32 0, i32 0, i32 1, i32 11, i32 0, null}
!7 = !{void ()* @main, !"main", null, !4, !8}
!8 = !{i32 0, i64 8388625, i32 4, !9}
!9 = !{i32 8, i32 1, i32 1}
Loading