Embed built-in headers in library binary#8445
Open
llvm-beanz wants to merge 5 commits into
Open
Conversation
This change modifies the dxcompiler library build to embed built-in headers as binary data in the library, and it connects the include handler such that angle bracket (`<>`) includes will resolve against the built-in headers if corresponding headers are not found on the filesystem. This allows users to override the headers by pointing to local copies on the filesystem, but also allows users to not worry about distributing the files with their compiler. The main tradeoff here is a larger compiler binary since we're embedding some big chunks of static data.
This is a cleanup to make the existing tests use the built-in headers rather than finding them on the filesystem.
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
../tools/clang/test/SemaHLSL/hlsl/embedded_headers/Inputs/enable_if.h
hekota
approved these changes
May 13, 2026
Comment on lines
+90
to
+92
| # Carry the generated .inc files as an explicit dependency of the | ||
| # library target so they're produced before HLSLEmbeddedHeaders.cpp is | ||
| # compiled. |
Member
There was a problem hiding this comment.
Can you please point me to where is the dependency declared? I can't find it...
Comment on lines
+14
to
+16
| The generated file declares a single variable named ``Data`` at namespace | ||
| scope. The intent is for the file to be ``#include``-ed inside a wrapping | ||
| namespace by the consumer. |
Member
There was a problem hiding this comment.
Suggested change
| The generated file declares a single variable named ``Data`` at namespace | |
| scope. The intent is for the file to be ``#include``-ed inside a wrapping | |
| namespace by the consumer. | |
| The generated file declares a single variable named ``Data`` at file | |
| scope. The intent is for the file to be ``#include``-ed inside a wrapping | |
| namespace by the consumer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the dxcompiler library build to embed built-in headers as binary data in the library, and it connects the include handler such that angle bracket (
<>) includes will resolve against the built-in headers if corresponding headers are not found on the filesystem.This allows users to override the headers by pointing to local copies on the filesystem, but also allows users to not worry about distributing the files with their compiler.
The main tradeoff here is a larger compiler binary since we're embedding some big chunks of static data.
This has some small changes to the Vulkan/SPIRV code since it will encourage angle bracket (
<>) includes for built-in headers.Fixes #8311