[SM6.10] Implement VectorAccumDescriptor Builtin#8448
Open
V-FEXrt wants to merge 2 commits into
Open
Conversation
V-FEXrt
commented
May 12, 2026
| @@ -33,7 +33,7 @@ target triple = "dxil-ms-dx" | |||
| @"\01?SharedArr@@3PAMA" = external addrspace(3) global [64 x float], align 4 | |||
|
|
|||
| define void @mainAS() { | |||
Collaborator
Author
There was a problem hiding this comment.
These tests updates still need to be moved per #8315
but I'm still kicking that can down the road:)
tex3d
approved these changes
May 13, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
I think it looks good, with just a "Matrix" nit and a question about whether we should have included an alignment parameter.
| db_dxil_param(0, "v", "", ""), | ||
| db_dxil_param(2, "$o", "vector", "vector to accumulate"), | ||
| db_dxil_param(3, "res", "handle", "buffer to accumulate into"), | ||
| db_dxil_param(4, "i32", "offset", "starting offset in the buffer"), |
Contributor
There was a problem hiding this comment.
I realize the spec proposal didn't include an alignment parameter, but I can't help but wonder if that was a mistake.
Comment on lines
+7180
to
+7182
| // Matrix parameters | ||
| Value *MatrixBuffer = CI->getArgOperand(2); | ||
| Value *MatrixOffset = CI->getArgOperand(3); |
Contributor
There was a problem hiding this comment.
"Matrix parameters"? MatrixBuffer? MatrixOffset? Seems a little copy-pasta to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements VectorAccumulateToDescriptor builtin and updates the header implementation.
Fixes #8416
Co-Authored-By: @pow2clk