Fix dead code in IndexConfigBuilder::build() logic, and other issues#686
Open
hpdic wants to merge 1 commit intomicrosoft:cpp_mainfrom
Open
Fix dead code in IndexConfigBuilder::build() logic, and other issues#686hpdic wants to merge 1 commit intomicrosoft:cpp_mainfrom
hpdic wants to merge 1 commit intomicrosoft:cpp_mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
This PR fixes a logical error in IndexConfigBuilder::build() where a safety check logic was duplicated, causing the logging code to become unreachable dead code. A couple of minor things: missing some header includes; string check is redundant.
Previously, there were two identical if (_dynamic_index && _num_frozen_pts == 0) checks.
The first check silently set _num_frozen_pts = 1.
The second check (which contained the warning log) would effectively become if (true && 1 == 0), which always evaluates to false.
As a result, the warning message "_num_frozen_pts passed as 0 ..." would never be printed.
The fix: I removed the first redundant check. Now the code correctly logs the warning before overriding the value to 1.
I also fixed a few other minor things like missing header includes and string checks.
Any other comments?