Enable Miri tests in CI with non-blocking execution#697
Open
Enable Miri tests in CI with non-blocking execution#697
Conversation
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable Miri tests in CI workflow
Enable Miri tests in CI with non-blocking execution and time tracking
Jan 20, 2026
arrayka
reviewed
Jan 20, 2026
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Copilot
AI
changed the title
Enable Miri tests in CI with non-blocking execution and time tracking
Enable Miri tests in CI with non-blocking execution
Jan 20, 2026
hildebrandmw
requested changes
Jan 23, 2026
diskann-quantization/src/algorithms/transforms/double_hadamard.rs
Outdated
Show resolved
Hide resolved
…rt miri-specific changes Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
arrayka
reviewed
Jan 24, 2026
…apply cfg!(miri) pattern to end_to_end_test Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
…or_tests module for miri Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
…istances_in_place Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (77.27%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 86.70% 86.70% -0.01%
==========================================
Files 398 398
Lines 74238 74262 +24
==========================================
+ Hits 64371 64387 +16
- Misses 9867 9875 +8
🚀 New features to boost your workflow:
|
hildebrandmw
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Enable Miri Tests in CI - Complete
All tasks completed successfully!
Summary
Successfully enabled Miri tests in the CI workflow with non-blocking execution and parallel processing. Tests have been optimized based on reviewer feedback.
Key Changes
.github/workflows/ci.ymlcontinue-on-error: trueto prevent CI blockingcargo +nightly miri nextest run --package diskann-quantizationtest_double_hadamardandtest_padding_hadamard(transforms)test_distances_in_place(kmeans/lloyds) - using#[cfg(not(miri))]for conditional compilationminmax_quantizer_testsmodule (entire test module)minmax_vector_testsmodule (entire test module)if cfg!(miri)pattern toend_to_end_testfor cleaner conditional setupCI Pipeline Structure
Time Impact Analysis
Quality & Security
The changes ensure Miri tests provide valuable feedback without blocking the CI pipeline or adding unnecessary complexity.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.