Add initial QEMU tests for diskann-wide.#719
Merged
hildebrandmw merged 14 commits intomainfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
========================================
Coverage 89.01% 89.01%
========================================
Files 428 428
Lines 78151 78294 +143
========================================
+ Hits 69563 69695 +132
- Misses 8588 8599 +11 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds QEMU-based testing to CI to validate that the architecture detection mechanisms work correctly when compiled for older x86-64 CPUs. It also fixes issue #694 by changing how compiler warnings are applied - using --config flag instead of overriding RUSTFLAGS environment variable, which was preventing .cargo/config.toml from being used.
Changes:
- Changed from
RUSTFLAGSenvironment variable toRUST_CONFIGwith--configflag to preserve.cargo/config.tomlsettings - Added new
qemujob that compiles tests forx86-64baseline and runs them under QEMU emulation to catch illegal instructions - Updated all cargo command invocations across test jobs to use
--config "$RUST_CONFIG"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
arkrishn94
approved these changes
Feb 5, 2026
metajack
approved these changes
Feb 5, 2026
arkrishn94
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds QEMU tests to CI to provide coverage of our architecture detection mechanisms.
QEMU is an emulator that, amongst other things, allows to run binaries as if we were running on an older CPU. This can help catch improper compilation when we target older CPUs. Unfortunately, user-space emulation of AVX-512 doesn't go the other way, so we can't quite use this to test our AVX-512 code on non-AVX-512 hosts.
Additionally, this closes #694 by changing the application of
-Dwarningsfrom overridingRUSTFLAGSto instead passing it via the--configflag. The former effectively disables our.cargo/config.toml, which in-turn disabled thex86-64-v3CPU target.An example of a failing run can be seen here, where the CI test fails due to an illegal instruction found by QEMU.