Fix compilation when tracing feature is disabled#721
Closed
Conversation
Co-authored-by: hildebrandmw <24898651+hildebrandmw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DiskANN compilation issue with tracing feature disabled
Fix compilation when tracing feature is disabled
Feb 4, 2026
Contributor
|
Closing in favor of #722 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiskANN 0.45.0 fails to compile with
--no-default-featuresbecause tracing macros unconditionally reference thetracingcrate.Changes
diskann/src/tracing.rs#[cfg(feature = "tracing")]guards to all macro definitionsdebug!andtrace!macros that expand to empty blockstracing::{debug, trace}when feature is enableddiskann/src/graph/index.rsuse tracing::{debug, trace}touse crate::tracing::{debug, trace}Original prompt
tracingfeature. #720💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.