Refactored the initialization counter to use std::atomic<int> for thr… #5979
Conversation
|
Sorry, this cannot work. The counter is visible in the header: Line 141 in cbe2ee9 so changing its type cannot be done in an ABI-compatible way. Why do you want to make it atomic in the first place? |
| int& ios_base::Init::_Init_cnt_func() { | ||
| return ios_base::Init::_Init_cnt; | ||
| } | ||
| static std::atomic<int> _Init_cnt{0}; |
There was a problem hiding this comment.
If you really want atomicity here, perhaps you can use atomic_ref.
|
This isn't getting past the early build for any architecture. We welcome pull requests but we really need contributors to validate their own changes, starting with actually building the STL and running some tests locally. This change is both impossible (can't mess with DLL-exported iostreams machinery) and unnecessary. There is no multithreading contention during initialization/teardown of the standard streams, as indicated by our current lack of locking/atomic ops. Finally, please provide more detailed descriptions in pull requests - not just what you're doing, but why. In this case, if you believe that multithreading contention is an issue we've totally neglected for 30 years, we'll need a writeup explaining the scenario. |
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
4 participants
Refactor with std::atomic