Skip to content

Consistently comment _WIN64 macro usage#6160

Open
AlexGuteniev wants to merge 5 commits intomicrosoft:mainfrom
AlexGuteniev:win64
Open

Consistently comment _WIN64 macro usage#6160
AlexGuteniev wants to merge 5 commits intomicrosoft:mainfrom
AlexGuteniev:win64

Conversation

@AlexGuteniev
Copy link
Contributor

No description provided.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner March 14, 2026 17:53
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 14, 2026
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Mar 14, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more inconsistent occurrences in <atomic>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally did not change them, keeping this change within existing _WIN64.

I think we also have remaining _M_IX86 that are good to be _WIN64 here:

#ifdef _M_IX86

#ifdef _M_IX86

And here:

#ifdef _M_IX86

#ifdef _M_IX86

#ifdef _M_IX86

#ifdef _M_IX86

#ifdef _M_IX86

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

Status: Ready To Merge

Development

Successfully merging this pull request may close these issues.

2 participants