Removed ConcurrentQueue storage of SocketEventAsyncArgs as it just ad…#27
Open
MarkCMann wants to merge 2 commits intomicrosoft:masterfrom
Open
Removed ConcurrentQueue storage of SocketEventAsyncArgs as it just ad…#27MarkCMann wants to merge 2 commits intomicrosoft:masterfrom
MarkCMann wants to merge 2 commits intomicrosoft:masterfrom
Conversation
added 2 commits
January 2, 2017 00:33
…into additional classes more easily in the future.
Tuatan
requested changes
Jan 4, 2017
Collaborator
Tuatan
left a comment
Tuatan
left a comment
There was a problem hiding this comment.
Please apply the review comments
| get | ||
| { | ||
| return this.socket.Available; | ||
| return this.availableSocketBytesGetter(); |
Collaborator
There was a problem hiding this comment.
That will throw NullRef exception if there are no subscribers, please handle that to provide more meaningful error instead.
Collaborator
|
Also, Mark please do pull request to develop branch, not the master. |
jomorri
force-pushed
the
master
branch
2 times, most recently
from
9ce2bdd to
2215cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ded overhead.