Don't exempt late bound symbols from EPC in presence of string index signature by Andarist · Pull Request #58190 · microsoft/TypeScript

Andarist · 2024-04-14T20:50:19Z

…signature

jakebailey · 2024-04-14T20:52:59Z

typescript-bot · 2024-04-14T20:53:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-14T21:11:44Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-04-14T21:16:38Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58190/merge:

Everything looks good!

typescript-bot · 2024-04-14T21:29:31Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{296,977k (± 0.01%)}	_{296,984k (± 0.01%)}	_~	_296,928k	_297,007k	_{p=0.261 n=6}
_{Parse Time}	_{2.70s (± 0.51%)}	_{2.71s (± 0.56%)}	_~	_2.68s	_2.72s	_{p=0.187 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.63%)}	_~	_0.81s	_0.82s	_{p=0.386 n=6}
_{Check Time}	_{8.31s (± 0.20%)}	_{8.33s (± 0.30%)}	_~	_8.29s	_8.36s	_{p=0.331 n=6}
_{Emit Time}	_{7.07s (± 0.42%)}	_{7.06s (± 0.32%)}	_~	_7.04s	_7.10s	_{p=0.625 n=6}
_{Total Time}	_{18.90s (± 0.13%)}	_{18.91s (± 0.26%)}	_~	_18.84s	_18.97s	_{p=0.520 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,974k (± 0.94%)}	_{192,401k (± 0.74%)}	_~	_191,794k	_195,323k	_{p=0.936 n=6}
_{Parse Time}	_{1.35s (± 0.30%)}	_{1.37s (± 1.10%)}	_~	_1.35s	_1.38s	_{p=0.071 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.59s (± 0.45%)}	_{9.58s (± 0.23%)}	_~	_9.54s	_9.60s	_{p=0.936 n=6}
_{Emit Time}	_{2.61s (± 0.95%)}	_{2.62s (± 0.31%)}	_~	_2.61s	_2.63s	_{p=0.181 n=6}
_{Total Time}	_{14.27s (± 0.40%)}	_{14.29s (± 0.15%)}	_~	_14.26s	_14.31s	_{p=0.418 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{348,866k (± 0.00%)}	_{348,851k (± 0.00%)}	_~	_348,837k	_348,875k	_{p=0.109 n=6}
_{Parse Time}	_{2.54s (± 0.39%)}	_{2.55s (± 0.41%)}	_~	_2.53s	_2.56s	_{p=0.343 n=6}
_{Bind Time}	_{0.89s (± 0.71%)}	_{0.89s (± 0.46%)}	_~	_0.88s	_0.89s	_{p=0.673 n=6}
_{Check Time}	_{7.07s (± 0.41%)}	_{7.04s (± 0.51%)}	_~	_7.00s	_7.08s	_{p=0.147 n=6}
_{Emit Time}	_{4.07s (± 0.26%)}	_{4.06s (± 0.33%)}	_~	_4.04s	_4.08s	_{p=0.358 n=6}
_{Total Time}	_{14.57s (± 0.13%)}	_{14.53s (± 0.17%)}	_{-0.04s (- 0.24%)}	_14.50s	_14.56s	_{p=0.030 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,960k (± 0.01%)}	_{302,951k (± 0.00%)}	_~	_302,940k	_302,961k	_{p=0.335 n=6}
_{Parse Time}	_{2.94s (± 0.90%)}	_{2.95s (± 0.90%)}	_~	_2.92s	_2.99s	_{p=0.570 n=6}
_{Bind Time}	_{1.43s (± 0.93%)}	_{1.44s (± 0.95%)}	_~	_1.43s	_1.47s	_{p=0.176 n=6}
_{Check Time}	_{9.37s (± 0.25%)}	_{9.37s (± 0.34%)}	_~	_9.33s	_9.41s	_{p=1.000 n=6}
_{Emit Time}	_{5.29s (± 0.57%)}	_{5.28s (± 0.65%)}	_~	_5.24s	_5.34s	_{p=0.936 n=6}
_{Total Time}	_{19.03s (± 0.29%)}	_{19.05s (± 0.25%)}	_~	_18.99s	_19.12s	_{p=0.572 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,588k (± 0.00%)}	_{511,594k (± 0.00%)}	_~	_511,565k	_511,609k	_{p=0.378 n=6}
_{Parse Time}	_{2.72s (± 0.68%)}	_{2.71s (± 0.64%)}	_~	_2.69s	_2.73s	_{p=0.451 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{0.99s (± 1.74%)}	_~	_0.96s	_1.01s	_{p=0.867 n=6}
_{Check Time}	_{17.25s (± 0.44%)}	_{17.17s (± 0.33%)}	_~	_17.09s	_17.25s	_{p=0.126 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.95s (± 0.39%)}	_{20.86s (± 0.33%)}	_~	_20.76s	_20.96s	_{p=0.127 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,748,639k (± 0.00%)}	_{1,748,684k (± 0.00%)}	_~	_1,748,637k	_1,748,737k	_{p=0.065 n=6}
_{Parse Time}	_{9.96s (± 0.58%)}	_{9.97s (± 1.29%)}	_~	_9.84s	_10.20s	_{p=0.688 n=6}
_{Bind Time}	_{3.35s (± 0.99%)}	_{3.34s (± 1.05%)}	_~	_3.31s	_3.41s	_{p=0.868 n=6}
_{Check Time}	_{81.38s (± 0.35%)}	_{81.57s (± 0.43%)}	_~	_81.10s	_82.12s	_{p=0.378 n=6}
_{Emit Time}	_{0.20s (± 3.79%)}	_{0.20s (± 5.89%)}	_~	_0.19s	_0.22s	_{p=0.796 n=6}
_{Total Time}	_{94.89s (± 0.30%)}	_{95.08s (± 0.35%)}	_~	_94.71s	_95.54s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,306,741k (± 0.01%)}	_{2,307,007k (± 0.03%)}	_~	_2,306,333k	_2,307,799k	_{p=0.689 n=6}
_{Parse Time}	_{6.02s (± 1.12%)}	_{6.02s (± 0.82%)}	_~	_5.96s	_6.11s	_{p=0.872 n=6}
_{Bind Time}	_{2.25s (± 0.87%)}	_{2.24s (± 1.26%)}	_~	_2.20s	_2.27s	_{p=0.872 n=6}
_{Check Time}	_{39.84s (± 0.33%)}	_{39.80s (± 0.36%)}	_~	_39.55s	_39.95s	_{p=0.689 n=6}
_{Emit Time}	_{3.22s (± 1.81%)}	_{3.17s (± 3.69%)}	_~	_3.02s	_3.32s	_{p=0.630 n=6}
_{Total Time}	_{51.35s (± 0.15%)}	_{51.27s (± 0.26%)}	_~	_51.04s	_51.44s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_{2,381,607k (± 0.03%)}	_{2,381,639k (± 0.04%)}	_~	_2,380,104k	_2,383,043k	_{p=0.689 n=6}
_{Parse Time}	_{7.68s (± 0.80%)}	_{7.65s (± 0.35%)}	_~	_7.61s	_7.68s	_{p=0.468 n=6}
_{Bind Time}	_{2.51s (± 0.87%)}	_{2.52s (± 0.82%)}	_~	_2.49s	_2.54s	_{p=0.747 n=6}
_{Check Time}	_{49.77s (± 0.33%)}	_{49.69s (± 0.91%)}	_~	_49.31s	_50.29s	_{p=0.423 n=6}
_{Emit Time}	_{3.95s (± 3.75%)}	_{3.92s (± 2.03%)}	_~	_3.76s	_3.97s	_{p=1.000 n=6}
_{Total Time}	_{63.93s (± 0.32%)}	_{63.80s (± 0.66%)}	_~	_63.43s	_64.35s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{419,105k (± 0.01%)}	_{419,077k (± 0.01%)}	_~	_419,041k	_419,098k	_{p=0.423 n=6}
_{Parse Time}	_{4.28s (± 3.84%)}	_{4.20s (± 0.36%)}	_~	_4.18s	_4.22s	_{p=0.357 n=6}
_{Bind Time}	_{1.58s (± 1.44%)}	_{1.59s (± 1.93%)}	_~	_1.56s	_1.64s	_{p=0.462 n=6}
_{Check Time}	_{22.28s (± 0.18%)}	_{22.31s (± 0.49%)}	_~	_22.20s	_22.49s	_{p=0.629 n=6}
_{Emit Time}	_{1.71s (± 0.96%)}	_{1.72s (± 1.51%)}	_~	_1.69s	_1.75s	_{p=1.000 n=6}
_{Total Time}	_{29.85s (± 0.57%)}	_{29.82s (± 0.40%)}	_~	_29.67s	_30.03s	_{p=0.873 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,913,590k (± 0.00%)}	_{2,913,480k (± 0.00%)}	_{-110k (- 0.00%)}	_2,913,292k	_2,913,629k	_{p=0.045 n=6}
_{Parse Time}	_{16.55s (± 0.52%)}	_{16.54s (± 0.48%)}	_~	_16.45s	_16.64s	_{p=0.936 n=6}
_{Bind Time}	_{4.95s (± 0.64%)}	_{5.02s (± 2.53%)}	_~	_4.90s	_5.18s	_{p=0.627 n=6}
_{Check Time}	_{88.26s (± 0.48%)}	_{88.20s (± 0.23%)}	_~	_87.94s	_88.41s	_{p=1.000 n=6}
_{Emit Time}	_{23.88s (± 0.75%)}	_{24.57s (± 7.73%)}	_~	_23.67s	_28.44s	_{p=0.688 n=6}
_{Total Time}	_{133.64s (± 0.30%)}	_{134.34s (± 1.33%)}	_~	_133.27s	_137.96s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{409,368k (± 0.01%)}	_{409,383k (± 0.01%)}	_~	_409,323k	_409,464k	_{p=0.936 n=6}
_{Parse Time}	_{3.93s (± 1.02%)}	_{3.92s (± 1.16%)}	_~	_3.84s	_3.97s	_{p=0.574 n=6}
_{Bind Time}	_{1.65s (± 0.25%)}	_{1.65s (± 0.91%)}	_~	_1.63s	_1.67s	_{p=0.498 n=6}
_{Check Time}	_{16.94s (± 0.37%)}	_{16.99s (± 0.24%)}	_~	_16.93s	_17.04s	_{p=0.199 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.53s (± 0.39%)}	_{22.56s (± 0.27%)}	_~	_22.48s	_22.62s	_{p=0.572 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{672,049k (± 0.03%)}	_{672,003k (± 0.02%)}	_~	_671,884k	_672,184k	_{p=0.689 n=6}
_{Parse Time}	_{4.11s (± 0.60%)}	_{4.14s (± 0.32%)}	_~	_4.13s	_4.16s	_{p=0.056 n=6}
_{Bind Time}	_{1.88s (± 0.78%)}	_{1.88s (± 0.93%)}	_~	_1.85s	_1.89s	_{p=1.000 n=6}
_{Check Time}	_{3.45s (± 0.54%)}	_{3.45s (± 0.57%)}	_~	_3.42s	_3.47s	_{p=1.000 n=6}
_{Emit Time}	_{0.03s (±14.39%)}	_{0.03s (±12.88%)}	_~	_0.03s	_0.04s	_{p=0.218 n=6}
_{Total Time}	_{9.47s (± 0.30%)}	_{9.49s (± 0.39%)}	_~	_9.45s	_9.54s	_{p=0.332 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-04-14T22:43:49Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58190/merge:

Everything looks good!

jakebailey · 2024-04-14T23:20:10Z

Shocking

@typescript-bot test top800

typescript-bot · 2024-04-14T23:20:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	✅ Results

typescript-bot · 2024-04-15T01:57:51Z

@jakebailey Here are the results of running the top 800 repos comparing main and refs/pull/58190/merge:

Everything looks good!

Andarist · 2024-04-15T06:51:52Z

Symbols are not that popular in the wild and often might not even be used directly so I'm not that shocked ;p

fatcerberus · 2024-04-17T03:35:15Z

Symbols are not that popular in the wild

Given that you either write something ugly like foo[Symbol.someBuiltInSymbol] = whatever or else foo[localSymVar] = bar which is syntactically indistinguishable from a string key access (and therefore potentially confusing), people shying away from symbols isn't that surprising. IMO symbols were a cool concept but they really needed specialized syntax.

…ties-vs-string-index-signature

typescript-bot · 2026-03-24T21:19:02Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Don't exempt late bound symbols from EPC in presence of string index …

99f5783

…signature

typescript-bot assigned ahejlsberg Apr 14, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 14, 2024

Merge remote-tracking branch 'origin/main' into fix/epc-symbol-proper…

0da2a3e

…ties-vs-string-index-signature

sandersn requested review from ahejlsberg and sheetalkamat June 14, 2024 21:09

Andarist mentioned this pull request Feb 6, 2025

Bug: @xstate/store Using Symbol for context key breaks static transitions statelyai/xstate#5189

Closed

Merge remote-tracking branch 'origin/main' into fix/epc-symbol-proper…

a398ca9

…ties-vs-string-index-signature

typescript-bot closed this Mar 24, 2026

github-project-automation bot moved this from Waiting on reviewers to Done in PR Backlog Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't exempt late bound symbols from EPC in presence of string index signature#58190

Don't exempt late bound symbols from EPC in presence of string index signature#58190
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Andarist:fix/epc-symbol-properties-vs-string-index-signature

Andarist commented Apr 14, 2024

Uh oh!

jakebailey commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024

tsc

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

jakebailey commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Apr 15, 2024

Uh oh!

Andarist commented Apr 15, 2024

Uh oh!

fatcerberus commented Apr 17, 2024

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Andarist commented Apr 14, 2024

Uh oh!

jakebailey commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024

tsc

Uh oh!

typescript-bot commented Apr 14, 2024

Uh oh!

jakebailey commented Apr 14, 2024

Uh oh!

typescript-bot commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 15, 2024

Uh oh!

Andarist commented Apr 15, 2024

Uh oh!

fatcerberus commented Apr 17, 2024

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

typescript-bot commented Apr 14, 2024 •

edited

Loading

typescript-bot commented Apr 14, 2024 •

edited

Loading