Normalize NoInferred tuple types in rest/spread positions#59682
Normalize NoInferred tuple types in rest/spread positions#59682Andarist wants to merge 5 commits intomicrosoft:mainfrom
NoInferred tuple types in rest/spread positions#59682Conversation
typescript-bot
added
the
For Uncommitted Bug
Andarist
changed the title
NoInferred tuple typesNoInferred tuple types in rest/spread positions
| else if (isParameter(declaration)) { | ||
| type = getWidenedTypeForVariableLikeDeclaration(declaration, /*reportErrors*/ true); | ||
| if (declaration.dotDotDotToken) { | ||
| type = normalizeNoInferSpread(type); |
There was a problem hiding this comment.
Maybe I'm thinking about this wrong, but shouldn't this actually be a part of expandParameters or something? IIRC that's where we normalize these out. Compared to sprinkling it around elsewhere.
There was a problem hiding this comment.
getExpandedParameters is only used by signatureToSignatureDeclarationHelper and node builder. This change has behavioral changes for inference etc so having this getExpandedParameters wouldn't work
typescript-bot
added
For Backlog Bug
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
4 participants
fixes #59668