Fixed an issue with mapped property symbol not displaying added | undefined when its origin symbol was optional#59957
Closed
Andarist wants to merge 12 commits intomicrosoft:mainfrom
Closed
Conversation
…defined` when its origin symbol was optional
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where mapped property symbols weren't displaying | undefined when their origin symbol was optional. The fix ensures that when TypeScript displays type information for mapped types, it correctly shows the union with undefined for properties that originated from optional properties.
- Refactors the
requiresAddingImplicitUndefinedfunction to improve readability and fix the logic for determining when to add implicit undefined - Adds comprehensive test coverage with 5 new fourslash tests covering various scenarios of mapped types with optional properties
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/checker.ts | Refactors the logic in requiresAddingImplicitUndefined to use early returns and adds proper type checking for declared types |
| tests/cases/fourslash/quickInfoMappedPropertyUnionUndefined1.ts | Tests mapped type behavior with exactOptionalPropertyTypes enabled |
| tests/cases/fourslash/quickInfoMappedPropertyUnionUndefined2.ts | Tests mapped type behavior in standard strict mode |
| tests/cases/fourslash/quickInfoMappedPropertyUnionUndefined3.ts | Tests nested mapped type transformations |
| tests/cases/fourslash/quickInfoMappedPropertyUnionUndefined4.ts | Tests simple mapped type with required modifier |
| tests/cases/fourslash/quickInfoMappedPropertyUnionUndefined5.ts | Tests RequiredKeys utility type scenario |
Comment on lines
+9
to
+15
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Comment on lines
+9
to
+15
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Comment on lines
+9
to
+15
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Comment on lines
+12
to
+18
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Comment on lines
+12
to
+18
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Comment on lines
+12
to
+18
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | ||
| //// type Literal/*2*/ = { a?: string | undefined }; | ||
| //// | ||
| //// type Res1/*3*/ = Required<Intermidiate>; | ||
| //// type Res2/*4*/ = Required<Literal>; | ||
|
|
||
| verify.quickInfoAt("1", `type Intermidiate = { |
There was a problem hiding this comment.
The type name 'Intermidiate' is misspelled. It should be 'Intermediate'.
Suggested change
| //// type Intermidiate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermidiate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermidiate = { | |
| //// type Intermediate/*1*/ = OptionalToUnionWithUndefined<{ a?: string }>; | |
| //// type Literal/*2*/ = { a?: string | undefined }; | |
| //// | |
| //// type Res1/*3*/ = Required<Intermediate>; | |
| //// type Res2/*4*/ = Required<Literal>; | |
| verify.quickInfoAt("1", `type Intermediate = { |
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59948
fixes #60411
fixes #62325