Skip to content

Create export declaration in Import_may_be_converted_to_a_default_import codefix when the original node has export modifier#61173

Closed
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Andarist:fix/include-export-in-convert-to-defaut
Closed

Create export declaration in Import_may_be_converted_to_a_default_import codefix when the original node has export modifier#61173
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Andarist:fix/include-export-in-convert-to-defaut

Conversation

@Andarist
Copy link
Copy Markdown
Contributor

fixes #61167

…port` codefix when the original node has export modifier
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 13, 2025
@jakebailey
Copy link
Copy Markdown
Member

I merged #61171 without noticing that this was also available to fix the same issue; this one seemingly fixes the bug by actually implementing it, though #61171 used a the right helper for detecting the modifier (so that could be done here).

@Andarist
Copy link
Copy Markdown
Contributor Author

Jinx. I haven't seen the other PR :D I synced this now with main and used suggested helper

@Andarist Andarist force-pushed the fix/include-export-in-convert-to-defaut branch from cf6dd34 to 6aabbb7 Compare February 22, 2025 10:27
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026
@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incorrect "Import may be converted to a default import" autofix for import export

4 participants