Skip to content

CodeFix and Diagnostic for Unnecessary Named Import#61219

Closed
sidlamsal wants to merge 6 commits intomicrosoft:mainfrom
SeniorSeminarGroup:importDiag
Closed

CodeFix and Diagnostic for Unnecessary Named Import#61219
sidlamsal wants to merge 6 commits intomicrosoft:mainfrom
SeniorSeminarGroup:importDiag

Conversation

@sidlamsal
Copy link
Copy Markdown

Fixes #56497

@sidlamsal
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@sidlamsal sidlamsal marked this pull request as ready for review February 18, 2025 19:26
@jakebailey
Copy link
Copy Markdown
Member

This PR says it fixes #56497, but that's not entirely the case; #56497 is asking for rename to not introduce foo as foo at all, whereas this PR adds a new suggestion that complains about foo as foo. That's a fine suggestion, but I would expect a PR that fixes #56497 to fix rename, and IIRC there's something odd about the way renaming works that may prevent that from working (but I can't remember what it was; I've wanted to fix this issue previously but gave up due to some issue...).

@sidlamsal
Copy link
Copy Markdown
Author

@jakebailey, understood. I came to a similar conclusion when trying to get rename to not include the redundancy. Would it be acceptable to create a new issue to close via this PR? Because, this PR has a lightweight band-aid "fix" for a non code-breaking bug. If not, do you have any insight/suggestion on fixing rename itself?

@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rename symbol command] Remove unnecessary named import

5 participants