fix(57026): Renaming on declaration whose name is a String Literal#61353
fix(57026): Renaming on declaration whose name is a String Literal#61353NamHaiBui wants to merge 7 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
NamHaiBui
changed the title
NamHaiBui
changed the title
|
@jakebailey @DanielRosenwasser |
| ////declare const fnc_1: <K extends keyof Case_1>(p: K) => void | ||
| //// | ||
| ////fn("Prop 1"/**/) | ||
| ////fnc_1("Att 2") |
There was a problem hiding this comment.
Why are these tests being modified rather than being added to, if anything?
There was a problem hiding this comment.
It was a duplicate test of renameStringLiteralTypes4 so I modified it to reflect one of the cases mentioned in the original issue.
There was a problem hiding this comment.
They are not duplicate tests. One is a type, the other is an interface.
There was a problem hiding this comment.
I'm sorry about that, I will revert changes and add an additional tests for type as well. Thank you and sorry for the oversight.
|
@jakebailey |
|
@jakebailey Hi, is it possible to get a review on this soon? |
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
4 participants
Fixes #57026