Improve union origin preservation in filtering-unionizing binary expressions by Andarist · Pull Request #61362 · microsoft/TypeScript

Andarist · 2025-03-06T08:55:58Z

…essions

Andarist · 2025-03-06T08:58:00Z

src/compiler/checker.ts

+
+        function getUnionOfLeftAndRightTypes(leftType: Type, rightType: Type, adjustLeft: (type: Type) => Type, unionReduction?: UnionReduction) {
+            const rightTypes = rightType.flags & TypeFlags.Union ? (rightType as UnionType).types : [rightType];
+            const includes = addTypesToUnion(/*typeSet*/ undefined, 0 as TypeFlags, rightTypes) & (TypeFlags.BaseOfLiteral | TypeFlags.Nullable);


It's not like all 3 cases require both BaseOfLiteral and Nullable preservation but there is no harm in treating them the same way here

jakebailey · 2025-06-30T23:10:45Z

@typescript-bot test it

typescript-bot · 2025-06-30T23:10:50Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-06-30T23:33:41Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: oauth-shim
Error:

TypeError: Cannot read properties of undefined (reading 'id')
Occurred while linting /mnt/vss/_work/1/DefinitelyTyped/types/oauth-shim/oauth-shim-tests.ts:1
Rule: "@definitelytyped/expect"
    at getTypeId (/mnt/vss/_work/1/s/built/local/typescript.js:65803:17)
    at binarySearch (/mnt/vss/_work/1/s/built/local/typescript.js:2972:33)
    at containsType (/mnt/vss/_work/1/s/built/local/typescript.js:65806:12)
    at /mnt/vss/_work/1/s/built/local/typescript.js:84896:67
    at mapType (/mnt/vss/_work/1/s/built/local/typescript.js:74490:89)
    at getUnionOfLeftAndRightTypes (/mnt/vss/_work/1/s/built/local/typescript.js:84892:9)
    at checkBinaryLikeExpressionWorker (/mnt/vss/_work/1/s/built/local/typescript.js:84669:76)
    at BinaryExpressionStateMachine.onExit (/mnt/vss/_work/1/s/built/local/typescript.js:84330:18)
    at Array.exit (/mnt/vss/_work/1/s/built/local/typescript.js:32144:28)
    at trampoline (/mnt/vss/_work/1/s/built/local/typescript.js:32220:42)

You can check the log here.

typescript-bot · 2025-06-30T23:48:52Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61362/merge:

Something interesting changed - please have a look.

Details

arktype

/mnt/ts_downloads/_/m/arktype/build.sh

[MISSING] error TS2345: Argument of type 'SyntaxKind.Identifier' is not assignable to parameter of type 'SyntaxKind'.
- /mnt/ts_downloads/_/m/arktype/ark/repo/jsdocGen.ts(343,25)
[MISSING] error TS2339: Property 'getDefinitions' does not exist on type 'JSDoc | JSDocText | JSDocLink | JSDocLinkCode | JSDocLinkPlain | SourceFile | Node<Node> | ... 194 more ... | CommaListExpression'.
- /mnt/ts_downloads/_/m/arktype/ark/repo/jsdocGen.ts(345,5)

debug

/mnt/ts_downloads/_/m/debug/tsconfig.json

[MISSING] error TS2630: Cannot assign to '_typeof' because it is a function.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(3,100)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(3,165)
[MISSING] error TS2339: Property 'type' does not exist on type 'Process'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(34,74)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/index.js(7,47)
[MISSING] error TS2339: Property '__nwjs' does not exist on type 'Process'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(34,112)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/index.js(7,106)
[MISSING] error TS2551: Property 'WebkitAppearance' does not exist on type 'CSSStyleDeclaration'. Did you mean 'webkitAppearance'?
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(45,138)
[MISSING] error TS2339: Property 'firebug' does not exist on type 'Console'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(46,70)
[MISSING] error TS2339: Property 'exception' does not exist on type 'Console'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(46,96)
[MISSING] error TS2367: This comparison appears to be unintentional because the types '"undefined"' and '"object"' have no overlap.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(100,10)
[MISSING] error TS2345: Argument of type 'IArguments' is not assignable to parameter of type '[message?: any, ...optionalParams: any[]]'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(100,148)
[MISSING] error TS2552: Cannot find name 'LocalStorage'. Did you mean 'localstorage'?
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(152,13)
[MISSING] error TS18046: 'error' is of type 'unknown'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/browser.js(177,45)
[MISSING] error TS2339: Property 'colors' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(51,24)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(51,60)
[MISSING] error TS2339: Property 'diff' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(80,12)
[MISSING] error TS2339: Property 'prev' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(81,12)
[MISSING] error TS2339: Property 'curr' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(82,12)
[MISSING] error TS2551: Property 'formatArgs' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'. Did you mean 'formatters'?
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(113,19)
[MISSING] error TS2339: Property 'log' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(114,24)
[MISSING] error TS2339: Property 'log' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(114,43)
[MISSING] error TS2339: Property 'useColors' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(120,35)
[MISSING] error TS2339: Property 'init' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(127,28)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(128,19)
[MISSING] error TS2339: Property 'save' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(159,17)
[MISSING] error TS2304: Cannot find name 'Mixed'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(230,13)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(231,14)
[MISSING] error TS2339: Property 'load' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: Mixed) => Mixed; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/common.js(244,34)
[MISSING] error TS2339: Property 'browser' does not exist on type 'Process'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/index.js(7,78)
[MISSING] error TS2307: Cannot find module 'supports-color' or its corresponding type declarations.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(29,31)
[MISSING] error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(53,39)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(55,48)
[MISSING] error TS2322: Type 'boolean' is not assignable to type 'string'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(54,5)
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(56,5)
[MISSING] error TS2322: Type 'null' is not assignable to type 'string | undefined'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(58,5)
[MISSING] error TS2322: Type 'number' is not assignable to type 'string'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(60,5)
[MISSING] error TS2345: Argument of type 'IArguments' is not assignable to parameter of type '[format?: any, ...param: any[]]'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(108,55)
[MISSING] error TS2322: Type 'string | undefined' is not assignable to type 'string'.
- /mnt/ts_downloads/_/m/debug/node_modules/debug/src/node.js(136,3)

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module './generated/version.js' or its corresponding type declarations.
- packages/browsers/src/CLI.ts#L20 in packages/browsers/src/tsconfig.esm.json
- packages/browsers/src/CLI.ts#L20 in packages/browsers/src/tsconfig.cjs.json

webpack

tsconfig.types.test.json

[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'Buffer<ArrayBuffer>'.
- lib/serialization/FileMiddleware.js#L281
[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- lib/wasm-sync/WebAssemblyGenerator.js#L518
[MISSING] error TS2307: Cannot find module 'webpack' or its corresponding type declarations.
[MISSING] error TS7006: Parameter 'loaders' implicitly has an 'any' type.
- test/configCases/loaders/pr-14384/PluginWithLoader.js#L16
[MISSING] error TS7006: Parameter 'normalModule' implicitly has an 'any' type.
- test/configCases/loaders/pr-14384/PluginWithLoader.js#L16

tsconfig.types.json

[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'Buffer<ArrayBuffer>'.
- lib/serialization/FileMiddleware.js#L281
[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- lib/wasm-sync/WebAssemblyGenerator.js#L518

tsconfig.json

[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'Buffer<ArrayBuffer>'.
- lib/serialization/FileMiddleware.js#L281
[MISSING] error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- lib/wasm-sync/WebAssemblyGenerator.js#L518

typescript-bot · 2025-06-30T23:51:58Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,376	_{-10 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{195,973k (± 0.79%)}	_{195,995k (± 0.73%)}	_~	_193,079k	_196,662k	_{p=0.575 n=6}
_{Parse Time}	_{1.60s (± 1.28%)}	_{1.60s (± 1.09%)}	_~	_1.58s	_1.63s	_{p=0.684 n=6}
_{Bind Time}	_{0.88s (± 0.92%)}	_{0.89s (± 0.92%)}	_~	_0.88s	_0.90s	_{p=0.666 n=6}
_{Check Time}	_{11.81s (± 0.63%)}	_{11.95s (± 0.65%)}	_{+0.14s (+ 1.16%)}	_11.84s	_12.06s	_{p=0.012 n=6}
_{Emit Time}	_{3.35s (± 3.76%)}	_{3.31s (± 0.59%)}	_~	_3.30s	_3.35s	_{p=0.871 n=6}
_{Total Time}	_{17.65s (± 0.62%)}	_{17.75s (± 0.51%)}	_~	_17.65s	_17.87s	_{p=0.172 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,753	_948,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,846	_410,842	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,245k (± 0.01%)}	_{1,225,264k (± 0.01%)}	_~	_1,225,159k	_1,225,361k	_{p=0.471 n=6}
_{Parse Time}	_{7.90s (± 0.79%)}	_{7.87s (± 0.66%)}	_~	_7.82s	_7.96s	_{p=0.630 n=6}
_{Bind Time}	_{2.29s (± 0.64%)}	_{2.28s (± 0.45%)}	_~	_2.26s	_2.29s	_{p=0.101 n=6}
_{Check Time}	_{38.12s (± 0.22%)}	_{38.07s (± 0.39%)}	_~	_37.88s	_38.32s	_{p=0.521 n=6}
_{Emit Time}	_{17.86s (± 0.72%)}	_{17.84s (± 0.62%)}	_~	_17.73s	_18.02s	_{p=1.000 n=6}
_{Total Time}	_{66.17s (± 0.25%)}	_{66.05s (± 0.37%)}	_~	_65.81s	_66.42s	_{p=0.471 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_2,509,183	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_892,716	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{2,804,489k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{10.49s (± 0.35%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{2.72s (± 0.82%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{100.56s (± 1.05%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{0.37s (± 1.41%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{114.14s (± 0.90%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,107	_{+26 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,474	_267,548	_{+74 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,879,022k (±11.88%)}	_{2,975,592k (±10.05%)}	_~	_2,364,627k	_3,099,003k	_{p=1.000 n=6}
_{Parse Time}	_{6.64s (± 1.33%)}	_{6.73s (± 0.68%)}	_~	_6.65s	_6.79s	_{p=0.093 n=6}
_{Bind Time}	_{2.17s (± 2.53%)}	_{2.18s (± 1.17%)}	_~	_2.15s	_2.21s	_{p=0.467 n=6}
_{Check Time}	_{42.82s (± 0.83%)}	_{43.02s (± 0.31%)}	_~	_42.79s	_43.16s	_{p=0.128 n=6}
_{Emit Time}	_{3.47s (± 1.76%)}	_{3.49s (± 2.93%)}	_~	_3.36s	_3.66s	_{p=0.688 n=6}
_{Total Time}	_{55.09s (± 0.68%)}	_{55.41s (± 0.23%)}	_{+0.32s (+ 0.58%)}	_55.28s	_55.64s	_{p=0.045 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,107	_{+26 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,474	_267,548	_{+74 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,040,090k (± 9.77%)}	_{2,944,989k (±11.52%)}	_~	_2,432,224k	_3,162,158k	_{p=0.689 n=6}
_{Parse Time}	_{6.90s (± 0.91%)}	_{6.84s (± 0.62%)}	_~	_6.78s	_6.90s	_{p=0.128 n=6}
_{Bind Time}	_{2.16s (± 2.43%)}	_{2.20s (± 1.67%)}	_~	_2.14s	_2.25s	_{p=0.147 n=6}
_{Check Time}	_{42.93s (± 0.59%)}	_{42.96s (± 0.88%)}	_~	_42.19s	_43.15s	_{p=0.298 n=6}
_{Emit Time}	_{3.56s (± 2.64%)}	_{3.55s (± 2.02%)}	_~	_3.45s	_3.66s	_{p=0.872 n=6}
_{Total Time}	_{55.56s (± 0.48%)}	_{55.54s (± 0.74%)}	_~	_54.71s	_55.77s	_{p=0.423 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,563	_{+15 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,156	_107,234	_{+78 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,716k (± 0.01%)}	_{441,862k (± 0.01%)}	_{+146k (+ 0.03%)}	_441,824k	_441,896k	_{p=0.005 n=6}
_{Parse Time}	_{2.89s (± 0.36%)}	_{2.89s (± 0.28%)}	_~	_2.88s	_2.90s	_{p=0.932 n=6}
_{Bind Time}	_1.11s	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.174 n=6}
_{Check Time}	_{15.76s (± 0.52%)}	_{15.87s (± 0.38%)}	_{+0.11s (+ 0.68%)}	_15.80s	_15.97s	_{p=0.045 n=6}
_{Emit Time}	_{1.29s (± 1.65%)}	_{1.31s (± 1.40%)}	_~	_1.28s	_1.33s	_{p=0.120 n=6}
_{Total Time}	_{21.05s (± 0.37%)}	_{21.18s (± 0.31%)}	_{+0.13s (+ 0.61%)}	_21.11s	_21.29s	_{p=0.024 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,367	_{+77 (+ 0.08%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,277k (± 0.05%)}	_{371,295k (± 0.06%)}	_~	_371,095k	_371,567k	_{p=0.936 n=6}
_{Parse Time}	_{2.91s (± 0.59%)}	_{2.89s (± 1.60%)}	_~	_2.81s	_2.94s	_{p=0.466 n=6}
_{Bind Time}	_{1.61s (± 0.82%)}	_{1.61s (± 1.22%)}	_~	_1.59s	_1.63s	_{p=0.566 n=6}
_{Check Time}	_{16.38s (± 0.32%)}	_{16.45s (± 0.59%)}	_~	_16.30s	_16.55s	_{p=0.126 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.24%)}	_{20.95s (± 0.39%)}	_~	_20.82s	_21.07s	_{p=0.298 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,499,298	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,177,218	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,549,697k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{18.50s (± 0.68%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{6.38s (±13.53%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{117.25s (± 2.57%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{39.71s (± 6.96%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{181.84s (± 2.35%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_318,019	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_137,705	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{472,222k (± 0.02%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{4.35s (± 0.86%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{1.77s (± 0.99%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{20.69s (± 0.40%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_0.00s	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{26.82s (± 0.40%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_665,978	_665,978	_~	_~	_~	_{p=1.000 n=6}
_Types	_199,345	_199,344	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{570,390k (± 0.01%)}	_{570,355k (± 0.03%)}	_~	_569,977k	_570,477k	_{p=0.378 n=6}
_{Parse Time}	_{4.27s (± 0.32%)}	_{4.27s (± 0.59%)}	_~	_4.24s	_4.30s	_{p=0.625 n=6}
_{Bind Time}	_{1.34s (± 0.73%)}	_{1.33s (± 0.63%)}	_{-0.02s (- 1.24%)}	_1.32s	_1.34s	_{p=0.018 n=6}
_{Check Time}	_{19.91s (± 0.31%)}	_{19.91s (± 0.47%)}	_~	_19.78s	_20.06s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.51s (± 0.25%)}	_{25.51s (± 0.41%)}	_~	_25.37s	_25.68s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-07-01T01:02:50Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61362/merge:

Something interesting changed - please have a look.

Details

ComposioHQ/composio

17 of 35 projects failed to build with the old tsc and were ignored

ts/examples/cloudflare-wrangler/tsconfig.json

error TS2307: Cannot find module '@composio/core' or its corresponding type declarations.
- ts/examples/cloudflare-wrangler/src/index.ts#L1
error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
- ts/examples/cloudflare-wrangler/src/index.ts#L8
- ts/examples/cloudflare-wrangler/src/index.ts#L36

ts/examples/cloudflare-wrangler/test/tsconfig.json

error TS2307: Cannot find module '@composio/core' or its corresponding type declarations.
- ts/examples/cloudflare-wrangler/src/index.ts#L1

reduxjs/redux-devtools

25 of 58 projects failed to build with the old tsc and were ignored

extension/tsconfig.json

error TS2307: Cannot find module '@redux-devtools/utils' or its corresponding type declarations.

vuetifyjs/vuetify

3 of 7 projects failed to build with the old tsc and were ignored

packages/docs/tsconfig.json

error TS2307: Cannot find module 'vuetify' or its corresponding type declarations.
error TS2307: Cannot find module 'vuetify/components/VChip' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L6
error TS2307: Cannot find module 'vuetify/components/VBtn' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L7
error TS2307: Cannot find module 'vuetify/components/VSwitch' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L8
error TS2307: Cannot find module 'vuetify/components/VIcon' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L9
error TS2307: Cannot find module 'vuetify/components/VSnackbarQueue' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L10
error TS2307: Cannot find module 'vuetify/iconsets/fa' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L13
error TS2307: Cannot find module 'vuetify/iconsets/md' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L14
error TS2307: Cannot find module 'vuetify/iconsets/mdi-svg' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L15
error TS2307: Cannot find module 'vuetify/locale' or its corresponding type declarations.
- packages/docs/src/plugins/vuetify.ts#L20

typescript-bot · 2026-03-24T21:21:34Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Improve union origin preservation in filtering-unionizing binary expr…

111feca

…essions

github-project-automation bot added this to PR Backlog Mar 6, 2025

github-project-automation bot moved this to Not started in PR Backlog Mar 6, 2025

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 6, 2025

Andarist commented Mar 6, 2025

View reviewed changes

typescript-bot closed this Mar 24, 2026

github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026

Conversation

Andarist commented Mar 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Jun 30, 2025

Uh oh!

typescript-bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 30, 2025

Uh oh!

typescript-bot commented Jun 30, 2025

/mnt/ts_downloads/_/m/arktype/build.sh

/mnt/ts_downloads/_/m/debug/tsconfig.json

Uh oh!

typescript-bot commented Jun 30, 2025

tsc

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Jun 30, 2025 •

edited

Loading