Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
69010 may be typo of 6910?|
Not ideal to edit the lcl files but it doesn't really matter. LGTM. Edit: Nah let's keep the git history clean on those |
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Revert all changes to the LCL files, these should not be edited by us
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Reverted all LCL file changes as requested. The main diagnosticMessages.json file still contains the fix (code 6910), but all LCL files have been restored to their original state. dc0ec58 |
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This PR fixes a typo in the diagnostic code from 69010 to 6910 in the diagnosticMessages.json file.
Issue
The diagnostic message
"module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"had code 69010, which appears to be a typo based on the sequential numbering pattern of surrounding diagnostic codes:"trueifcomposite,falseotherwise""module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"← Should be 6910"Computed from the list of input files""Platform specific"Changes Made
src/compiler/diagnosticMessages.jsonsrc/loc/lcl/to use the correct code 6910Verification
The fix is minimal and surgical - only changing the diagnostic code number while preserving all functionality and maintaining the sequential numbering pattern.
Fixes #61971.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.