Skip to content

Fixed Japanese translations for messages 1259, 2556, 2620, 2621, 2706, and 18046#62120

Closed
hanohrs wants to merge 1 commit intomicrosoft:mainfrom
hanohrs:incorrect-japanese-translations-for-messages-1259-2556-2620-2621-2706-and-18046
Closed

Fixed Japanese translations for messages 1259, 2556, 2620, 2621, 2706, and 18046#62120
hanohrs wants to merge 1 commit intomicrosoft:mainfrom
hanohrs:incorrect-japanese-translations-for-messages-1259-2556-2620-2621-2706-and-18046

Conversation

@hanohrs
Copy link
Copy Markdown

@hanohrs hanohrs commented Jul 24, 2025

Fixes #53337

Testing

I did not add unit tests for this change because:

  • Previous changes to this file have not included test additions, following the established pattern for locale-specific message updates
  • I manually verified the fix by running /path/to/TypeScript/built/local/tsc.js --locale ja locally and confirmed that the expected error messages are displayed correctly

The change is a straightforward localization fix that aligns the Japanese error message with the English version, and manual testing confirms the expected behavior.

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jul 24, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 24, 2025
@jakebailey
Copy link
Copy Markdown
Member

These files are maintained by our localization team and can't really be updated externally (they push them here). I don't think we can accept this PR.

@hanohrs
Copy link
Copy Markdown
Author

hanohrs commented Jul 24, 2025

I'm disappointed to hear that, as I submitted this PR because issue #53337 has a "Help Wanted" label.

I understand you can't accept this PR, but I hope the incorrect translations can still be fixed. Messages 2620, 2621, and 2706 have meanings that are opposite to what they should be. How can I help get these corrected?

@RyanCavanaugh
Copy link
Copy Markdown
Member

Sorry for the incorrect tag on that one, I missed something there.

I'll try to track down who is in charge of the loc files these days.

@hanohrs
Copy link
Copy Markdown
Author

hanohrs commented Jul 25, 2025

@RyanCavanaugh
Thank you. I hope the translations can be fixed.

@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Mar 24, 2026
@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incorrect Japanese translations for messages 1259, 2556, 2620, 2621, 2706, and 18046

4 participants