Skip to content

Fixed reference searches related to JsxNamespacedName#62124

Closed
Andarist wants to merge 5 commits intomicrosoft:mainfrom
Andarist:fix/jsx-namespaces-find-all-refs
Closed

Fixed reference searches related to JsxNamespacedName#62124
Andarist wants to merge 5 commits intomicrosoft:mainfrom
Andarist:fix/jsx-namespaces-find-all-refs

Conversation

@Andarist
Copy link
Copy Markdown
Contributor

fixes #62123

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 25, 2025
@Andarist Andarist marked this pull request as ready for review July 26, 2025 08:29
Copilot AI review requested due to automatic review settings July 26, 2025 08:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes reference searches for JSX namespaced names (e.g., prop:foo in JSX attributes) by addressing issues where find all references and rename operations weren't working correctly for these syntax elements.

  • Updates reference and rename functionality to properly handle JSX namespaced names
  • Adds support for JSX namespaced names in name table initialization and node eligibility checks
  • Includes comprehensive test cases with baseline expectations for both rename and find all references operations

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/cases/fourslash/renameOnJsxNamespacedName1.ts Test case for rename functionality on JSX namespaced names
tests/cases/fourslash/findAllReferencesOnJsxNamespacedName1.ts Test case for find all references functionality on JSX namespaced names
tests/baselines/reference/renameOnJsxNamespacedName1.baseline.jsonc Expected baseline output for rename test
tests/baselines/reference/findAllReferencesOnJsxNamespacedName1.baseline.jsonc Expected baseline output for find all references test
src/services/utilities.ts Core utility functions updated to handle JSX namespaced names in location adjustment and property name detection
src/services/services.ts Name table initialization updated to include JSX namespaced names
src/services/rename.ts Rename eligibility check updated to include JSX namespaced names
src/services/findAllReferences.ts Find all references functionality updated with JSX namespaced name support

@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go-to-Definition/Find all References/… with JsxNamespacedName are not working

4 participants