Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a localization update pull request that updates diagnostic error message translations across multiple languages. The PR updates TypeScript error messages related to ECMAScript module syntax restrictions in CommonJS modules, improving message clarity and accuracy while adding new diagnostic messages with better guidance for developers.
- Updates error message translations for module syntax restrictions across 13 languages
- Replaces "ESM syntax" terminology with more precise "ECMAScript imports and exports" language
- Adds new diagnostic message with detailed guidance for resolving module syntax conflicts
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Turkish translations for ECMAScript module syntax error messages |
| src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Russian translations for ECMAScript module syntax error messages |
| src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Portuguese (Brazil) translations for ECMAScript module syntax error messages |
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Polish translations for ECMAScript module syntax error messages |
| src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Korean translations for ECMAScript module syntax error messages |
| src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Japanese translations for ECMAScript module syntax error messages |
| src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Italian translations for ECMAScript module syntax error messages |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates French translations for ECMAScript module syntax error messages |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Spanish translations for ECMAScript module syntax error messages |
| src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates German translations for ECMAScript module syntax error messages |
| src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Czech translations for ECMAScript module syntax error messages |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Traditional Chinese translations for ECMAScript module syntax error messages |
| src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updates Simplified Chinese translations for ECMAScript module syntax error messages |
| <Val><![CDATA[ECMAScript imports and exports cannot be written in a CommonJS file under 'verbatimModuleSyntax'.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[A sintaxe ESM não é permitida em um módulo CommonJS quando 'module' estiver definido como 'preserve'.]]></Val> | ||
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax".]]></Val> |
There was a problem hiding this comment.
The word "texttimModuleSyntax" appears to be a typo. It should be "verbatimModuleSyntax" to match the English source text.
Suggested change
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax".]]></Val> | |
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "verbatimModuleSyntax".]]></Val> |
| <Val><![CDATA[ECMAScript imports and exports cannot be written in a CommonJS file under 'verbatimModuleSyntax'. Adjust the 'type' field in the nearest 'package.json' to make this file an ECMAScript module, or adjust your 'verbatimModuleSyntax', 'module', and 'moduleResolution' settings in TypeScript.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[A sintaxe ESM não é permitida em um módulo CommonJS quando a opção "verbatimModuleSyntax" estiver habilitada.]]></Val> | ||
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "texttimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val> |
There was a problem hiding this comment.
Multiple instances of "texttimModuleSyntax" should be "verbatimModuleSyntax". This typo appears twice in this translation and needs to be corrected.
Suggested change
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "texttimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "texttimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val> | |
| <Val><![CDATA[Importações e exportações ECMAScript não podem ser gravadas em um arquivo CommonJS em "verbatimModuleSyntax". Ajuste o campo "type" no "package.json" mais próximo para tornar esse arquivo um módulo ECMAScript ou ajuste as configurações "verbatimModuleSyntax", "module" e "moduleResolution" no TypeScript.]]></Val> |
jakebailey
approved these changes
Jul 30, 2025
|
🤖 AI Assistant: Task completed: PR #62150: LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to... |
1 similar comment
|
🤖 AI Assistant: Task completed: PR #62150: LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to... |
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250730202607176 to main with localized lcls