Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new TypeScript compiler error that prevents comparison operations (except equality) between string literals. The change introduces validation to catch potentially problematic string literal comparisons during compilation.
Key changes:
- Adds a new error diagnostic for string literal comparisons
- Implements compiler logic to detect and report string literal comparison operations
- Creates test case to validate the new error behavior
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/cases/compiler/StringComp.ts | Test case demonstrating string literal comparison that should trigger the new error |
| tests/baselines/reference/stringComp.* | Baseline files for the new compiler test (types, symbols, and JS output) |
| src/compiler/diagnosticMessages.json | New error message for string literal comparison restriction |
| src/compiler/checker.ts | Compiler logic to detect and report string literal comparison errors |
Comments suppressed due to low confidence (2)
… group (microsoft#62006) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #