Fix 'Changes overlap' error in move to file refactoring

[Vedant224]

Fix 'Changes overlap' error in move to file refactoring

• Add updateImportsInTargetFile() function to handle import cleanup
• Use ImportAdder API to coordinate import changes and prevent overlapping edits
• Resolves issue where moving code to files with existing imports failed

Fixes #62378

Description

This PR fixes the "Changes overlap" error that occurs when using the "move to file" refactor on code that needs to be moved to a file with existing imports. The issue was caused by uncoordinated text changes that overlapped when both removing imports from the target file and adding new content.

Problem

When moving code to a file that already contains imports, the refactor would fail with:

Changes overlap

This happened because the move-to-file refactor was making conflicting text changes:

1. Removing unused imports from the target file
2. Adding new imports and moved code to the same file

These operations weren't coordinated, causing text ranges to overlap.

Solution

• Added updateImportsInTargetFile() function: Uses the ImportAdder API to safely coordinate import removal
• Enhanced coordination: All import-related text changes now go through the ImportAdder system to prevent overlapping edits
• Updated orchestration: Modified getNewStatementsAndRemoveFromOldFile() to call the new function when working with existing target files

Technical Details

The fix leverages TypeScript's existing codefix.ImportAdder infrastructure, which is specifically designed to coordinate import-related text changes without conflicts. This follows the established patterns used throughout the TypeScript codebase for similar import manipulation scenarios.

Testing

• All existing moveToFile test suite continues to pass (98,861 tests)
• No regressions in core refactoring functionality
• Implementation follows established TypeScript codebase patterns

[Vedant224]

@microsoft-github-policy-service agree