Fix findAllReferences for export= namespace with ES6 imports#62412
Closed
mag123c wants to merge 5 commits intomicrosoft:mainfrom
Closed
Fix findAllReferences for export= namespace with ES6 imports#62412mag123c wants to merge 5 commits intomicrosoft:mainfrom
mag123c wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Replace direct exports Map access with TypeScript's official API for more robust export= namespace + ES6 import support.
abd2e2f to
eb1e93f
Compare
…b.com/mag123c/TypeScript into fix/find-all-references-export-equals
eb1e93f to
9beaba2
Compare
jakebailey
requested changes
Sep 22, 2025
Member
jakebailey
left a comment
There was a problem hiding this comment.
This seems too special-case-y to me. #62428 seems more plausible as a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62348
This fixes findAllReferences for the
export = namespace+ ES6 import pattern.Problem
When using:
Find All References doesn't work.
Solution
Added fallback symbol resolution in findAllReferences.ts for import specifiers when standard resolution fails.
Testing
Added test case findAllReferencesExportEqualsNamespace.ts. All existing tests pass