fix: property access on union types with generic conditionals with any by mdm317 · Pull Request #62467 · microsoft/TypeScript

mdm317 · 2025-09-19T18:11:12Z

RyanCavanaugh · 2025-09-19T19:00:53Z

typescript-bot · 2025-09-19T19:00:59Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-09-19T19:23:31Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-09-19T19:27:32Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/62467/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-09-19T19:56:51Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,394k (± 0.76%)}	_{194,065k (± 0.93%)}	_~	_192,791k	_196,450k	_{p=0.378 n=6}
_{Parse Time}	_{1.30s (± 0.94%)}	_{1.30s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.109 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.56%)}	_{9.73s (± 0.15%)}	_~	_9.71s	_9.75s	_{p=0.334 n=6}
_{Emit Time}	_{2.75s (± 0.93%)}	_{2.75s (± 0.44%)}	_~	_2.74s	_2.77s	_{p=0.871 n=6}
_{Total Time}	_{14.53s (± 0.32%)}	_{14.51s (± 0.15%)}	_~	_14.48s	_14.54s	_{p=0.573 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,914	_948,912	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,884	_410,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,245,561k (± 0.00%)}	_{1,245,555k (± 0.00%)}	_~	_1,245,510k	_1,245,601k	_{p=0.936 n=6}
_{Parse Time}	_{6.56s (± 0.83%)}	_{6.58s (± 0.77%)}	_~	_6.51s	_6.64s	_{p=0.572 n=6}
_{Bind Time}	_{1.88s (± 0.27%)}	_{1.88s (± 0.29%)}	_~	_1.87s	_1.88s	_{p=0.640 n=6}
_{Check Time}	_{32.12s (± 0.37%)}	_{32.15s (± 0.33%)}	_~	_31.96s	_32.23s	_{p=0.873 n=6}
_{Emit Time}	_{14.81s (± 0.29%)}	_{14.80s (± 0.51%)}	_~	_14.69s	_14.88s	_{p=1.000 n=6}
_{Total Time}	_{55.37s (± 0.21%)}	_{55.40s (± 0.20%)}	_~	_55.27s	_55.53s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,543,258	_2,543,258	_~	_~	_~	_{p=1.000 n=6}
_Types	_902,717	_902,717	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,828,966k (± 0.00%)}	_{2,829,120k (± 0.00%)}	_{+154k (+ 0.01%)}	_2,828,911k	_2,829,207k	_{p=0.031 n=6}
_{Parse Time}	_{8.75s (± 0.54%)}	_{8.75s (± 0.62%)}	_~	_8.69s	_8.82s	_{p=1.000 n=6}
_{Bind Time}	_{2.20s (± 0.73%)}	_{2.19s (± 0.88%)}	_~	_2.16s	_2.22s	_{p=0.625 n=6}
_{Check Time}	_{86.86s (± 1.27%)}	_{87.38s (± 1.79%)}	_~	_86.41s	_90.50s	_{p=0.298 n=6}
_{Emit Time}	_{0.59s (±120.28%)}	_{0.30s (± 1.79%)}	_~	_0.30s	_0.31s	_{p=0.663 n=6}
_{Total Time}	_{98.41s (± 1.05%)}	_{98.63s (± 1.60%)}	_~	_97.71s	_101.80s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,083	_1,237,083	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,748	_259,748	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,485,832k (±11.92%)}	_{2,607,086k (±11.38%)}	_~	_2,364,319k	_3,092,062k	_{p=0.378 n=6}
_{Parse Time}	_{5.16s (± 0.82%)}	_{5.16s (± 1.16%)}	_~	_5.09s	_5.26s	_{p=0.810 n=6}
_{Bind Time}	_{1.76s (± 0.76%)}	_{1.79s (± 1.83%)}	_~	_1.75s	_1.84s	_{p=0.121 n=6}
_{Check Time}	_{35.12s (± 0.56%)}	_{35.00s (± 0.82%)}	_~	_34.68s	_35.48s	_{p=0.298 n=6}
_{Emit Time}	_{3.01s (± 1.34%)}	_{3.00s (± 1.06%)}	_~	_2.97s	_3.06s	_{p=0.575 n=6}
_{Total Time}	_{45.05s (± 0.48%)}	_{44.95s (± 0.68%)}	_~	_44.68s	_45.51s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,083	_1,237,083	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,748	_259,748	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,159,833k (± 0.05%)}	_{3,158,174k (± 0.02%)}	_{-1,660k (- 0.05%)}	_3,157,424k	_3,159,279k	_{p=0.031 n=6}
_{Parse Time}	_{6.84s (± 0.69%)}	_{6.84s (± 0.60%)}	_~	_6.79s	_6.89s	_{p=1.000 n=6}
_{Bind Time}	_{2.16s (± 1.67%)}	_{2.14s (± 1.04%)}	_~	_2.11s	_2.16s	_{p=0.121 n=6}
_{Check Time}	_{42.62s (± 0.39%)}	_{42.57s (± 0.27%)}	_~	_42.43s	_42.76s	_{p=0.748 n=6}
_{Emit Time}	_{3.46s (± 2.77%)}	_{3.54s (± 2.87%)}	_~	_3.40s	_3.64s	_{p=0.261 n=6}
_{Total Time}	_{55.08s (± 0.26%)}	_{55.07s (± 0.34%)}	_~	_54.84s	_55.35s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,423	_262,423	_~	_~	_~	_{p=1.000 n=6}
_Types	_103,918	_103,918	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,526k (± 0.01%)}	_{440,487k (± 0.00%)}	_~	_440,466k	_440,514k	_{p=0.093 n=6}
_{Parse Time}	_{4.35s (± 1.02%)}	_{4.33s (± 0.65%)}	_~	_4.28s	_4.36s	_{p=0.418 n=6}
_{Bind Time}	_{1.63s (± 0.72%)}	_{1.63s (± 0.50%)}	_~	_1.62s	_1.64s	_{p=0.315 n=6}
_{Check Time}	_{23.55s (± 0.44%)}	_{23.47s (± 0.34%)}	_~	_23.37s	_23.56s	_{p=0.198 n=6}
_{Emit Time}	_{1.90s (± 0.61%)}	_{1.89s (± 1.28%)}	_~	_1.86s	_1.92s	_{p=0.568 n=6}
_{Total Time}	_{31.43s (± 0.48%)}	_{31.33s (± 0.28%)}	_~	_31.20s	_31.41s	_{p=0.149 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,064k (± 0.02%)}	_{370,148k (± 0.05%)}	_~	_370,006k	_370,499k	_{p=0.689 n=6}
_{Parse Time}	_{3.53s (± 0.79%)}	_{3.51s (± 1.21%)}	_~	_3.46s	_3.57s	_{p=0.470 n=6}
_{Bind Time}	_{1.96s (± 1.40%)}	_{1.97s (± 0.75%)}	_~	_1.96s	_1.99s	_{p=0.225 n=6}
_{Check Time}	_{20.39s (± 0.24%)}	_{20.40s (± 0.28%)}	_~	_20.33s	_20.50s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.88s (± 0.23%)}	_{25.89s (± 0.24%)}	_~	_25.82s	_25.96s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,880,234	_3,880,234	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,221,282	_1,221,282	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,697,367k (± 0.00%)}	_{3,697,327k (± 0.00%)}	_~	_3,697,122k	_3,697,566k	_{p=0.688 n=6}
_{Parse Time}	_{18.71s (± 0.67%)}	_{18.73s (± 0.32%)}	_~	_18.65s	_18.82s	_{p=0.810 n=6}
_{Bind Time}	_{6.05s (± 1.11%)}	_{6.02s (± 0.66%)}	_~	_5.98s	_6.09s	_{p=0.336 n=6}
_{Check Time}	_{123.69s (± 3.86%)}	_{125.17s (± 3.47%)}	_~	_121.13s	_132.31s	_{p=0.471 n=6}
_{Emit Time}	_{38.56s (± 8.63%)}	_{39.69s (± 9.62%)}	_~	_37.07s	_45.60s	_{p=0.423 n=6}
_{Total Time}	_{187.01s (± 2.68%)}	_{189.62s (± 2.42%)}	_~	_183.87s	_194.29s	_{p=0.336 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_361,435	_361,429	_{-6 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_158,724	_158,722	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{515,839k (± 0.02%)}	_{515,906k (± 0.02%)}	_~	_515,777k	_516,104k	_{p=0.378 n=6}
_{Parse Time}	_{4.43s (± 0.37%)}	_{4.44s (± 0.34%)}	_~	_4.42s	_4.46s	_{p=0.088 n=6}
_{Bind Time}	_{1.92s (± 1.35%)}	_{1.91s (± 2.44%)}	_~	_1.87s	_1.99s	_{p=0.629 n=6}
_{Check Time}	_{21.87s (± 0.40%)}	_{21.86s (± 0.51%)}	_~	_21.69s	_22.00s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.174 n=6}
_{Total Time}	_{28.21s (± 0.26%)}	_{28.22s (± 0.58%)}	_~	_27.99s	_28.41s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_672,791	_672,791	_~	_~	_~	_{p=1.000 n=6}
_Types	_201,962	_201,962	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{574,863k (± 0.02%)}	_{574,939k (± 0.02%)}	_~	_574,721k	_575,009k	_{p=0.092 n=6}
_{Parse Time}	_{4.15s (± 0.91%)}	_{4.19s (± 0.92%)}	_~	_4.14s	_4.25s	_{p=0.092 n=6}
_{Bind Time}	_{1.34s (± 1.61%)}	_{1.32s (± 1.59%)}	_~	_1.30s	_1.35s	_{p=0.105 n=6}
_{Check Time}	_{20.63s (± 1.92%)}	_{20.41s (± 1.60%)}	_~	_20.21s	_21.07s	_{p=0.422 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.13s (± 1.55%)}	_{25.93s (± 1.25%)}	_~	_25.75s	_26.58s	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-09-19T20:19:01Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62467/merge:

Everything looks good!

typescript-bot · 2026-03-24T21:22:37Z

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

fix: property access on union types with generic conditionals

f1f578f

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 19, 2025

mdm317 changed the title ~~fix: property access on union types with generic conditionals~~ fix: property access on union types with generic conditionals with any Sep 19, 2025

mdm317 marked this pull request as ready for review September 20, 2025 07:34

typescript-bot closed this Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: property access on union types with generic conditionals with any#62467

fix: property access on union types with generic conditionals with any#62467
mdm317 wants to merge 1 commit intomicrosoft:mainfrom
mdm317:fix-62466

mdm317 commented Sep 19, 2025

Uh oh!

RyanCavanaugh commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025

tsc

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mdm317 commented Sep 19, 2025

Uh oh!

RyanCavanaugh commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Sep 19, 2025

tsc

Uh oh!

typescript-bot commented Sep 19, 2025

Uh oh!

typescript-bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Sep 19, 2025 •

edited

Loading