Fix type curve property in WaveShaperNode#62489
Closed
Korilakkuma wants to merge 1 commit intomicrosoft:mainfrom
Korilakkuma:fix/type-of-curve-property-in-wave-shaper-node
Closed
Fix type curve property in WaveShaperNode#62489Korilakkuma wants to merge 1 commit intomicrosoft:mainfrom Korilakkuma:fix/type-of-curve-property-in-wave-shaper-node
curve property in WaveShaperNode#62489Korilakkuma wants to merge 1 commit intomicrosoft:mainfrom
Korilakkuma:fix/type-of-curve-property-in-wave-shaper-node
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Collaborator
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
Korilakkuma
deleted the
fix/type-of-curve-property-in-wave-shaper-node
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Setting
Float32Arraytocurveproperty inWaveShaperNode, typescript@5.9.2 build is failed. (Screenshot is below).Refer to W3C Web Audio API Specification,
curveproperty type is notFloat32Array<ArrayBuffer>butFloat32Array.By the way, typescript@5.8.3 was not this problem. Therefore, it seems that there is degression on 5.9.x.
Fixes #