LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251001192403117 to main#62521
Merged
jakebailey merged 1 commit intomainfrom Oct 9, 2025
Conversation
typescript-bot
added
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates localized diagnostic messages across multiple languages (Portuguese, Korean, Spanish, and Traditional Chinese) in TypeScript's localization files.
Key changes:
- Fixed grammatical error in English diagnostic message from "assertions" to "assertion"
- Added new diagnostic message for side-effect imports (error code 2882)
- Updated corresponding translations in all affected languages
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl | Portuguese localization updates with grammar fix and new side-effect import message |
| src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl | Korean localization updates with translation improvements and new message |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Spanish localization updates with grammar fix and new message |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Traditional Chinese localization updates with grammar fix and new message |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Cannot find module or type declarations for side-effect import of '{0}'.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[No se pueden encontrar declaraciones de módulo o tipo para la importación de efectos secundarios de ''{0}".]]></Val> |
There was a problem hiding this comment.
There's a mismatched quote mark at the end of the Spanish translation. It should be a single quote {0}' instead of {0}\".
Suggested change
| <Val><![CDATA[No se pueden encontrar declaraciones de módulo o tipo para la importación de efectos secundarios de ''{0}".]]></Val> | |
| <Val><![CDATA[No se pueden encontrar declaraciones de módulo o tipo para la importación de efectos secundarios de '{0}'.]]></Val> |
jakebailey
approved these changes
Oct 9, 2025
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251001192403117
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251001192403117 to main with localized lcls