Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503 to main#62531

Closed
csigs wants to merge 1 commit intomainfrom
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503
Closed

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503 to main#62531
csigs wants to merge 1 commit intomainfrom
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503

Conversation

@csigs
Copy link
Copy Markdown
Member

@csigs csigs commented Oct 2, 2025

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503 to main with localized lcls

Copilot AI review requested due to automatic review settings October 2, 2025 19:23
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Oct 2, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 2, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates localized diagnostic message resources: adjusts the English source text from plural to singular for the const assertion diagnostic and adds a new diagnostic for missing module/type declarations on side-effect imports across multiple locales.

  • Singularizes the const assertion diagnostic key and message.
  • Adds new diagnostic message 2882 translations (side-effect import) for all touched locales.
  • Updates corresponding localized target strings.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl Updated const assertion string (introduced a Turkish typo); added new diagnostic 2882.
src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882 (Czech translation formatting issue).
src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl Singularized const assertion message; added new diagnostic 2882.
Comments suppressed due to low confidence (2)

@jakebailey jakebailey closed this Oct 9, 2025
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Oct 9, 2025
@jakebailey jakebailey deleted the lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251002192259503 branch October 9, 2025 19:50
@microsoft microsoft locked as resolved and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants